search

mozilla-mobile / firefox-ios

Firefox for iOS
Mozilla Public License 2.0
12.09k stars 2.88k forks source link

L10nSnapshotTests `testIntro` fixes w/ Nimbus if possible #14463

Closed data-sync-user closed 1 week ago

data-sync-user commented 1 year ago

┆Issue is synchronized with this Jira Task

data-sync-user commented 1 year ago

➤ Isabel Rios Escobar commented:

Hi Roux Buciu , wondering about the the fixes needed for this test to be enabled again. I have updated it so that it passes by changing the IDs of the buttons but not sure what else is needed.

data-sync-user commented 1 year ago

➤ Roux Buciu commented:

I think that should be fine, but eventually, I think that we want to figure out howe many cards in the onboarding, so we can dynamically swap through them? I dunno. It just seems like this being under Nimbus will complicate things? Or we just test the default, which works for me.

github-actions[bot] commented 1 month ago

This issue has been automatically marked as stale. Has the issue been fixed, or does it still require the community's attention? Please leave any comment to keep this issue opened. It will be closed automatically if no further update occurs in the next 30 days. Thank you for your contributions!

github-actions[bot] commented 1 week ago

Closing this issue after a prolonged period of inactivity. If this issue is still present in the latest release, please create a new issue linking to this one, with up-to-date information. Thank you!