search

mozilla-mobile / firefox-ios

Firefox for iOS
Mozilla Public License 2.0
12.14k stars 2.9k forks source link

Update dark mode theming in Autofill Credit Cards Settings #14694

Closed jeffreygee closed 1 year ago

jeffreygee commented 1 year ago

Steps to reproduce

  1. Turn device mode into Dark Mode
  2. Go to Autofill Credit Cards

Expected behavior

  1. Default credit card icon displaying as black instead of Dark mode color, and not very visible
  2. The ‘Close’, 'Cancel’, ‘Edit’, and ‘Save’ actions on Dark Mode are not using the Dark Mode color.

Actual behavior

  1. Icon displayed in dark mode icon color
  2. Link texts are using dark mode theming.
  3. Disabled link texts updated to 'TextDisabled'

Device & build information

Notes

Attachments: Link texts:

Dark icon:

┆Issue is synchronized with this Jira Task

nbhasin2 commented 1 year ago

Fixed here: https://github.com/mozilla-mobile/firefox-ios/pull/14679

Note: The card for visa small icon will get fixed in another ticket as that might require a new icon or us changing how we handle template image color

data-sync-user commented 1 year ago

➤ Andrei Bodea commented:

Verified as fixed on v9000 (31641) with iPhone 13 Pro (15.7.1).

To be checked when the official v116 official version will be sent to QA