Shortcuts top/bottom space changed in RTL locale (ar)

mozilla-mobile / firefox-ios

Firefox for iOS

Mozilla Public License 2.0

12.23k stars 2.93k forks source link

Shortcuts top/bottom space changed in RTL locale (ar) #14922

Open aalaaeid opened 1 year ago

aalaaeid commented 1 year ago

Steps to reproduce

Set the language to AR.
Launch FF -> settings -> Homepage
tap Shortcuts
Observe the top/bottom space of Rows cell.

Expected behavior

The top/bottom space of Rows cell should be the same as they appear in LTR locale.

Actual behavior

The top/bottom space of Rows cell changed in RTL locale (ar).

Device & build information

Device: iPhone 11
Build version: v114.1 (31594)
First seen version: N/A

Notes

Attachments: IMG!UNITO-UNDERSCORE!8805

IMG!UNITO-UNDERSCORE!8806

┆Issue is synchronized with this Jira Task

lmarceau commented 1 year ago

I'm wondering if fixing https://github.com/mozilla-mobile/firefox-ios/issues/14921 will fix this one as well 🤞

aalaaeid commented 1 year ago

I'm wondering if fixing #14921 will fix this one as well 🤞

Yeah, I think they are related, but I'm not sure, so I opened two separately. 👀

github-actions[bot] commented 1 day ago

This issue has been automatically marked as stale. Has the issue been fixed, or does it still require the community's attention? Please leave any comment to keep this issue opened. It will be closed automatically if no further update occurs in the next 30 days. Thank you for your contributions!