search

mozilla-mobile / firefox-ios

Firefox for iOS
Mozilla Public License 2.0
12.2k stars 2.92k forks source link

Navigation bar and PDF view controls overlap #15184

Open rnewman opened 1 year ago

rnewman commented 1 year ago

See screenshot. IMG!UNITO-UNDERSCORE!4308

┆Issue is synchronized with this Jira Task

arkumari2000 commented 1 year ago

@rnewman How can I contribute to resolve this issue? Please help. Thanks in advance.

rnewman commented 1 year ago

@rnewman How can I contribute to resolve this issue? Please help. Thanks in advance.

I no longer work on Firefox; you’ll have to ask a current maintainer for advice.

arkumari2000 commented 1 year ago

I no longer work on Firefox; you’ll have to ask a current maintainer for advice.

@rnewman How to find who is the current maintainer?

lmarceau commented 1 year ago

Hello @arkumari2000, if you are looking for issues to contribute on, we have a set that are great for contributors under our "Contributor OK" list. You can also have a read through our contributing guidelines here, and join us to chat on Element if there's anything!

mattreaganmozilla commented 8 months ago

Quick update: this issue is still occurring in v122.0 (iPhone 12 Mini)

Screenshot 2024-01-13 at 8 30 38 PM

data-sync-user commented 8 months ago

➤ Matthew Reagan commented:

The fix applied was to simply hide this accessory view (with the back/forward arrows and Done button) entirely for PDF content, since it does not appear to be functional currently for PDFs. I wasn’t able to identify any conflicts with this approach but if anyone has further context or concerns about hiding this view please LMK and I can look into a different solution. (cc Andrei Bodea Norberto Andres Furlan)

QA testing note: for validation we just need to verify that when viewing PDFs the accessory view does not show (and overlap the bottom toolbar). Also need to regression test that view for non-PDF content like web forms to ensure it still works as expected.

data-sync-user commented 6 months ago

➤ Norberto Andres Furlan commented:

Matt Reagan I understand this change is merged (based on the PR). Can you confirm? If so we can move it to “Needs QA”.

data-sync-user commented 6 months ago

➤ Matt Reagan commented:

Norberto Andres Furlan Yes it should be fixed now; it looks like it was in QA Needed but one of the scripts may have updated the status (possibly incorrectly).

data-sync-user commented 6 months ago

➤ Adina Petridean commented:

Verified as fixed on v9000(40702), with iPhone 14 Pro Max (16.2).

!PDF.jpeg|width=430,height=932,alt="PDF.jpeg"!

data-sync-user commented 5 months ago

➤ Adina Petridean commented:

Verified as fixed using v127.0 (41813) with iPhone 14 Pro Max (16.2).