search

mozilla-mobile / firefox-ios

Firefox for iOS
Mozilla Public License 2.0
12.24k stars 2.94k forks source link

`effective_tld_names.dat` is not used #15501

Closed q2r5 closed 1 month ago

q2r5 commented 1 year ago

The code to load effective_tld_names.dat was removed in 26d06b09ed8d91deb736052c17719d516ba20a33 and was replaced with EffectiveTLDNames.swift

It would need to be determined if the loading code needs to be re-added, or if the update job for the file also/instead needs to update the relevant swift file.

┆Issue is synchronized with this Jira Task

lmarceau commented 1 year ago

Thank you @q2r5 that was missed on my end, I guess that's why we should never trust comments 😬!

It's interesting, this change was actually made to improve startup time. In this case it looks like we should keep the current .swift format, but update the cron job to update it. I guess the next step would be to determine how to go from the .dat file to the .swift one.

I am also wondering if var combined = ETLD_NAMES_LIST_PART_1! + ETLD_NAMES_LIST_PART_2! is still needed, as this was for Xcode 12.5.

cc: @isabelrios

github-actions[bot] commented 2 months ago

This issue has been automatically marked as stale. Has the issue been fixed, or does it still require the community's attention? Please leave any comment to keep this issue opened. It will be closed automatically if no further update occurs in the next 30 days. Thank you for your contributions!

github-actions[bot] commented 1 month ago

Closing this issue after a prolonged period of inactivity. If this issue is still present in the latest release, please create a new issue linking to this one, with up-to-date information. Thank you!