search

mozilla-mobile / firefox-ios

Firefox for iOS
Mozilla Public License 2.0
12.2k stars 2.92k forks source link

Suggestions not cleared with private data #15931

Open Bachsau opened 1 year ago

Bachsau commented 1 year ago

Steps to reproduce

Expected behavior

Actual behavior

Device & build information

┆Issue is synchronized with this Jira Task

lmarceau commented 1 year ago

Hello @Bachsau, thanks for opening this ticket. The suggestions are filled from user history and saved bookmarks, but also from top domains.

Could you check if the website you are navigating to is also a saved bookmark (which aren't cleared when private data is cleared), or if this website is in our top domains list? If so this would explain why it gets suggested even thought history was cleared. Thank you!

Bachsau commented 1 year ago

Already done before filing the bug. None is the case and the suggestions are sometimes up to a single page that has been typed. Some of them had been bookmarks but removed long ago and some not even that. I really made sure to remove any reference to a site, cleared everything through every option (history, website data, private data) and re-started the app. Yet it still suggests complete URLs, like a single profile on Instagram I visited months ago but also URLs from domains that are 100% not on any top sites list.

PS: Firefox is synced and clearing the history does not seem to purge it from the servers like it is done when a single history entry is removed manually.

lmarceau commented 1 year ago

I think clearing data from the application won't clear data from the sync account. So the suggestion could appear from the sync account it seems. @dnarcese will be able to tell us what should happen in this case

Bachsau commented 1 year ago

I just disabled history sync and cleared everything again, but nothing changed. It still remembers everything in the suggestions even though it's not bookmarked and the history is empty.

Edit: I'm not 100% sure, but it seems like only URLs that had been typed in or had been bookmarked in the past are suggested. Definitely not everything ever visited.

Edit #2: I can find said domains in the empty! history when I search for them using the magnifying glass icon on the history screen. When I swipe left and delete the entry, it re-appears when I search again.

tusharC95 commented 4 months ago

URL suggestion visible on iPhone SE 2nd Gen on iOS 16.4 even after clearing from synced device. Same behavior NOT observed on iPhone 15 Pro 17.5. Attaching video for reference.

https://github.com/mozilla-mobile/firefox-ios/assets/64319078/2ec76112-a058-4710-815b-38d075a752ed

tusharC95 commented 4 months ago

"Clear All Website Data" and "Clear Private Data" in Data Management inside Settings should delete all the history data present locally on device. Tabs open in synced devices should be the only suggestion visible in URL tab after clearing local data. @Bachsau please check and let us know if clearing cache and local data from Data Management solved the issue. Thank you!

Bachsau commented 4 months ago

It did not, or otherwise I wouldn't have reported the bug. However, I've since gone ahead and ditched Firefox for all the bugs and bad integration between Desktop & Mobile. I don't know if it's fixed now, but since you ask me to do just what I did (multiple times) before reporting the bug, I guess it's not. But I don't think you can easily reproduce this on a clean install. It was more like some data got stuck somewhere after months of use. While some of the recent data were deleted, there were just some history entries that kept coming back in the suggestions forever.

data-sync-user commented 4 months ago

➤ Tushar Chitnavis commented:

Thank you for pointing out the issue. This ticket led to discovery of other bug. We are more than happy to receive additional inputs from you.