search

mozilla-mobile / firefox-ios

Firefox for iOS
Mozilla Public License 2.0
12.22k stars 2.93k forks source link

Update highlights to only show 2 lines and hide button if neccessary #16381

Closed data-sync-user closed 1 year ago

data-sync-user commented 1 year ago

Spec Update:

  1. Show 2 lines of text with the 2nd faded out.
  2. If there's only one highlight snippet for the first available highlight category, do not show the fade at the bottom.
  3. If there are no more highlights to display in expanded mode, do not show the "Show more" button.

Matching task on Android: https://bugzilla.mozilla.org/show_bug.cgi?id=1851711

┆Issue is synchronized with this Jira Task

data-sync-user commented 1 year ago

➤ Alina Moldovan commented:

Verified as fixed using V9000 (34632) and iPhone 14+ (16.0.3).

Winnie Teichmann could you please confirm that the actual behavior is correct?

  1. Looks good to me:

  2. !image-20230928-132644.png|width=364,height=581!

  1. It seems that the bottom of the text is fade faded out

!image-20230928-132958.png|width=386,height=568!

  1. Looks good to me

!image-20230928-133324.png|width=380,height=456!

  1. Section is missing in case no snippets are available. This also looks correct.

!image-20230928-133447.png|width=391,height=423!

data-sync-user commented 1 year ago

➤ Alina Moldovan commented:

Found another case: https://www.amazon.com/DREAM-PAIRS-Athletic-Sneakers-Running/dp/B08JPRX2BG/ref=mp_s_a_1_1_sspa?_encoding=UTF8&content-id=amzn1.sym.129c608e-f1a7-4184-a40e-42ea15d09c85&crid=162GNE57OBSW9&keywords=Kid+Shoes&pd_rd_r=70b2efe1-3cf8-44cd-9598-21598e649055&pd_rd_w=t8mln&pd_rd_wg=HycNS&pf_rd_p=129c608e-f1a7-4184-a40e-42ea15d09c85&pf_rd_r=9DFJZDKYW3XRZ63NCTKH&qid=1695908873&refinements=p_n_deal_type%3A23566064011&rnid=23566063011&sprefix=kid+shoes%2Caps%2C202&sr=8-1-spons&sp_csd=d2lkZ2V0TmFtZT1zcF9waG9uZV9zZWFyY2hfYXRm&psc=1 ( https://www.amazon.com/DREAM-PAIRS-Athletic-Sneakers-Running/dp/B08JPRX2BG/ref=mp_s_a_1_1_sspa?_encoding=UTF8&content-id=amzn1.sym.129c608e-f1a7-4184-a40e-42ea15d09c85&crid=162GNE57OBSW9&keywords=Kid+Shoes&pd_rd_r=70b2efe1-3cf8-44cd-9598-21598e649055&pd_rd_w=t8mln&pd_rd_wg=HycNS&pf_rd_p=129c608e-f1a7-4184-a40e-42ea15d09c85&pf_rd_r=9DFJZDKYW3XRZ63NCTKH&qid=1695908873&refinements=p_n_deal_type%3A23566064011&rnid=23566063011&sprefix=kid+shoes%2Caps%2C202&sr=8-1-spons&sp_csd=d2lkZ2V0TmFtZT1zcF9waG9uZV9zZWFyY2hfYXRm&psc=1|smart-link ) In this case not sure if the second line should be faded out:

!Skype_Video3.mp4|width=888,height=1920!

data-sync-user commented 1 year ago

➤ Winnie Teichmann commented:

Alina Moldovan all of these look good to me. The blur happens in following cases:

We do not check for number of lines of these reviews.

data-sync-user commented 1 year ago

➤ Alina Moldovan commented:

Revalidated this feature based on the Winnie’s comments using FF v9000 (35230) and iPhone 14+ (16.0.3)

Rules are respected for all cases except for the case when only one highlight group exists and it contains two one line reviews. Since there are no more highlights to display in expanded mode, we should not show the "Show more" button. A different issue was bug was logged for this.

The following cases were validated:

  1. Highlight groups = 1: 1, reviews = 1, review lines = 2+ => NO faded out, NO Show more button https://www.amazon.com/ABEIFAN-Keyboard-Case-iPad-10-5/dp/B09H6KW7JK !image-20231017-160632.png|width=367,height=432!
  2. Highlight groups = 1: 1, reviews = 1, review lines = 2 => NO faded out, NO Show more button https://www.amazon.com/JACKYLED-Branches-Wisteria-Hanging-Artificial/dp/B0B5CR1ZWL !image-20231017-160807.png|width=360,height=485!
  3. Highlight groups = 1: 1, reviews = 1, review lines = 1: => NO faded out, NO Show more button https://www.amazon.com/Hananona-Artificial-Flowers-Arrangement-Centerpieces/dp/B0B2F22DP2 !image-20231017-161453.png|width=354,height=405!
  4. Highlight groups = 1: 1, reviews = 2 / 2+, First review lines = 2+ : => Faded out, Show more button https://www.amazon.com/GoPro-HERO10-Black-Waterproof-Stabilization/dp/B09QD75B95

!image-20231017-170811.png|width=365,height=569!

  1. Highlight groups = 1: 1, reviews = 2 / 2+, First review lines = 2 : => Faded out, Show more button https://www.amazon.com/GoPro-HERO10-Black-Commerce-Packaging/dp/B0B2FF8CP4 !image-20231017-171734.png|width=369,height=436!
  2. Highlight groups = 1: 1, reviews = 2 / 2+, First review lines = 1 : => Faded out, Show more button https://www.amazon.com/Halloween-Decorations-Spiders-Stretch-Supplies/dp/B07HMRZSWT !image-20231017-172015.png|width=368,height=451!
  3. Highlight groups = 2 / 2+, first group no of reviews =1, First review lines = 2+ => Faded out, Show more button https://www.amazon.com/AKASO-Brave-4K30-Action-Camera/dp/B09HC51L11 !image-20231017-180359.png|width=371,height=445!
  4. Highlight groups = 2 / 2+, first group no of reviews =1, First review lines = 2 => Faded out, Show more button https://www.amazon.com/Dragon-Touch-Underwater-Waterproof-Accessories/dp/B08N4LMFNB !image-20231017-175144.png|width=379,height=438!
  5. Highlight groups = 2 / 2+, first group no of reviews =1, First review lines = 1 => Faded out, Show more button https://www.amazon.com/dp/B0CHR7CDPF
    !image-20231017-174203.png|width=373,height=434!
  6. Highlight groups = 2 / 2+, first group no of reviews =2+, First review lines = 2+ => Faded out, Show more button https://www.amazon.com/Stemmed-Stainless-Steel-Wine-Glasses/dp/B08HD52L84 !image-20231017-174520.png|width=361,height=537!
  7. Highlight groups = 2 / 2+, first group no of reviews =2+, First review lines = 2 => Faded out, Show more button https://www.amazon.com/AKASO-Brave-4K30FPS-Underwater-Batteries/dp/B08B3MFDQL !image-20231017-175547.png|width=359,height=565!
  8. Highlight groups = 2 / 2+, first group no of reviews =2+, First review lines = 1 => Faded out, Show more button https://www.amazon.com/HONGDAK-Accessories-Waterproof-Silicone-Adjustable/dp/B0B5CVD7SV !image-20231017-175912.png|width=349,height=499!