mozilla-mobile / firefox-ios

Firefox for iOS
Mozilla Public License 2.0
12.15k stars 2.91k forks source link

Long-press on a link using magic keyboard does not bring up the menu #16821

Open fabmene opened 11 months ago

fabmene commented 11 months ago

Steps to reproduce

  1. Attach magic keyboard
  2. Open new tab in Firefox, go to page with a link
  3. long-press the link using the trackpad on the magic keyboard

Expected behavior

A small preview of the link is shown, adjacent to which is a menu for opening, sharing, bookmarking and copying that link

Actual behavior

The small preview is shown, but no menu appears.

Device & build information

Notes

Attachments:

In the video, the link is long-pressed thrice: First via trackpad (no menu appears) then via touch input (menu appears) finally again via trackpad (menu appears).

https://github.com/mozilla-mobile/firefox-ios/assets/60504866/7d88a156-8d94-41ad-88dc-90b03ab33d16

After any link is long-pressed once by touch, that tab seems to behave correctly for trackpad long-presses as well, as shown with the third long-press in the video. Once a new tab is opened, the issue is observed again in that tab.

┆Issue is synchronized with this Jira Bug

dataports commented 4 months ago

@DanielDervishi is working on this issue

data-sync-user commented 4 months ago

➤ Nishant Bhasin commented:

Its back opened for Contributor-OK

PARAIPAN9 commented 3 months ago

Hey @fabmene, just a heads up to let you know that a fix went in main branch. I believe the fix would get in the next release. Please let us know if it works as expected. TY for your bug report!!

fabmene commented 3 months ago

Cool, thank you!

data-sync-user commented 3 months ago

➤ Andrei Bodea commented:

Verified as fixed on v9000 (43147) with iPad Pro (16.4.1).

CallieJo commented 2 months ago

I am still seeing this bug in Firefox version 128.0 (43182) on an iPad Pro (17.5.1)

data-sync-user commented 2 months ago

➤ Sorin Paraipan commented:

Data Sync Hi, the fix will be in v129, that’s why you are still seeing it.

data-sync-user commented 2 months ago

➤ Andrei Bodea commented:

Verified as fixed on v129 (44023), with iPad Pro (16.4.1).