Open data-sync-user opened 11 months ago
➤ Alina Moldovan commented:
Winnie Teichmann could you please add more details for the QA team to know what should test here?
➤ Winnie Teichmann commented:
Alina Moldovan please check that the buttons of Report back in Stock card and Re-analysis card look correct and are accessible.
➤ Diana Andreea Barladeanu commented:
Validated on v123(38163), with iPhone 15 (17.0).
The re-analysis card looks correct and is accessible.
The “Report back in stock” button is accessible, but it has an incorrect font color in dark mode. It is white instead of black.
!dark.jpeg|width=295,height=640!
@bmihai23 would you might having a look into last comment?
Here's the attached image
@lmarceau, I checked and run the app on two versions of iOS 17 and this is how it looks. I didn't find anything suspect in my code
@alinamoldovan84 could you help us to know what would need to change here? Thank you 🙏
➤ Alina Moldovan commented:
The “Report back in Stock“ button is not displayed correctly while the device is in dark mode. The text is displayed on white instead of black.
Please see the attached screenshot:
!image-20240130-130611.png|width=364,height=446!
Please note that the issue reproduces in both nightly and 123 beta builds.
➤ Winnie Teichmann commented:
Alina Moldovan The screenshot you posted looks exactly like the card should look like in dark mode according to Figma ( https://www.figma.com/file/VE5xayz3yOSB5qOATUU9Im/Mobile-Shopping-Experience-MVP?type=design&node-id=5283-77854&mode=dev ). The button text should be white in light and dark mode.
LinkButton and primaryButton are subclass of LegacyResizableButton. They should instead be
contentEdgeInsets
and other warnings should be fixed┆Issue is synchronized with this Jira Task