mozilla-mobile / firefox-ios

Firefox for iOS
Mozilla Public License 2.0
12.17k stars 2.92k forks source link

Fix contentEdgeInsets in FakespotMessageCardView #17184

Open data-sync-user opened 11 months ago

data-sync-user commented 11 months ago

LinkButton and primaryButton are subclass of LegacyResizableButton. They should instead be

⚠️  'contentEdgeInsets' was deprecated in iOS 15.0: This property is ignored when using UIButtonConfiguration
        roundedButton.contentEdgeInsets = UIEdgeInsets(

┆Issue is synchronized with this Jira Task

data-sync-user commented 8 months ago

➤ Alina Moldovan commented:

Winnie Teichmann could you please add more details for the QA team to know what should test here?

data-sync-user commented 8 months ago

➤ Winnie Teichmann commented:

Alina Moldovan please check that the buttons of Report back in Stock card and Re-analysis card look correct and are accessible.

data-sync-user commented 8 months ago

➤ Diana Andreea Barladeanu commented:

Validated on v123(38163), with iPhone 15 (17.0).

The re-analysis card looks correct and is accessible.

The “Report back in stock” button is accessible, but it has an incorrect font color in dark mode. It is white instead of black.

!dark.jpeg|width=295,height=640!

lmarceau commented 8 months ago

@bmihai23 would you might having a look into last comment?

Here's the attached image dark

bmihai23 commented 8 months ago

@lmarceau, I checked and run the app on two versions of iOS 17 and this is how it looks. I didn't find anything suspect in my code

Screenshot 2024-01-29 at 8 34 43 PM
lmarceau commented 8 months ago

@alinamoldovan84 could you help us to know what would need to change here? Thank you 🙏

data-sync-user commented 8 months ago

➤ Alina Moldovan commented:

The “Report back in Stock“ button is not displayed correctly while the device is in dark mode. The text is displayed on white instead of black.

Please see the attached screenshot:

!image-20240130-130611.png|width=364,height=446!

image

Please note that the issue reproduces in both nightly and 123 beta builds.

data-sync-user commented 7 months ago

➤ Winnie Teichmann commented:

Alina Moldovan The screenshot you posted looks exactly like the card should look like in dark mode according to Figma ( https://www.figma.com/file/VE5xayz3yOSB5qOATUU9Im/Mobile-Shopping-Experience-MVP?type=design&node-id=5283-77854&mode=dev ). The button text should be white in light and dark mode.