search

mozilla-mobile / firefox-ios

Firefox for iOS
Mozilla Public License 2.0
12.13k stars 2.9k forks source link

Update telemetry for multi-window #17537

Closed data-sync-user closed 2 months ago

data-sync-user commented 9 months ago

Action items are TBD.

┆Issue is synchronized with this Jira Task

data-sync-user commented 9 months ago

➤ Matthew Reagan commented:

Update: per team discussion we may look into trying to remove tabmanager entirely from telemetry

data-sync-user commented 4 months ago

➤ Matt Reagan commented:

Note: the tab manager reference in TelemetryWrapper has been fixed by https://github.com/mozilla-mobile/firefox-ios/pull/19966 ( https://github.com/mozilla-mobile/firefox-ios/pull/19966|smart-link )

data-sync-user commented 4 months ago

➤ Matt Reagan commented:

I’ve been attempting to do a quick telemetry audit to identify areas requiring updates for multi-window. But there are quite a few events that are ambiguous; for ex. currently we record events for tab counts each time the app goes into the background, but those are recorded for each BVC, so it's unclear whether we should leave this as-is (record individual events for each window on iPad) or refactor this to record a single event that combines the tab counts across all windows etc.

Realistically, I'm guessing it's impractical to audit all of our telemetry code prior to the MVP; I think we're probably going to have to update some of this after MW 1.0 ships, but on the flip side I'm concerned about those tasks being overlooked until someone notices an unexpected change in our metrics.

Posting here to solicit feedback/thoughts on the best parth forward for this; I’m curious if anyone thinks we should do a complete pass of all the telemetry before we ship MW. (Doing so could potentially be a significant undertaking, and would probably require working with someone on our data collection side to confirm how we want to resolve things like the tab count mentioned above)

For now I’m planning to move forward only with updates/fixes for telemetry which are critical for multi-window functionality.

(cc Norberto Andres Furlan Orla Mitchell )

data-sync-user commented 3 months ago

➤ Matt Reagan commented:

Going to close for now; I believe we will need to revisit this on an ad-hoc/as-needed basis for individual metrics once the remaining work for MW MVP is wrapped up. Will reopen if needed or if any additional feedback comes in.