mozilla-mobile / firefox-ios

Firefox for iOS
Mozilla Public License 2.0
12.21k stars 2.93k forks source link

iOS: Language standardization for Credential Management features #17619

Closed data-sync-user closed 9 months ago

data-sync-user commented 11 months ago

User Problem:

Across credential management features, we are, in places, inconsistent in the terminology we use (e.g. sometimes we say “login”, and other times we say “password”). In other cases, we use terms that are imprecise—for example, credit cards to mean any card-based payment method. This is a disruptive user experience.

Goal:

We’d like to (a) use consistent terminology across features and (b) choose terms that speak to the capabilities of the features as they are built today, while leaving some flexibility for near-term changes.

┆Issue is synchronized with this Jira Task

data-sync-user commented 11 months ago

➤ Katie Lower commented:

Hello! For whoever picks up this ticket, wanted to make sure that this Google sheet ( https://docs.google.com/spreadsheets/d/1Wof2_8o1PoVqbgJyxe7tdIn6qYBIcWlal3T9kJOhwK0/edit#gid=64342838 ) I put together is referenced / followed for the string changes. A few notes about the sheet:

If you have any questions as you’re working the ticket, please let me know. Thank you!

data-sync-user commented 11 months ago

➤ Nishant Bhasin commented:

Roux Buciu Would you have some time to take a look at this please

data-sync-user commented 10 months ago

➤ Diana Andreea Barladeanu commented:

Validated on v122 (37071), with iPhone 15 (17.1).

The terminology changes look properly. But in the account creation section, we still have “Credit Cards” option. Please confirm that this is correct. Thanks!

!IMG_0004.PNG|width=1179,height=2556!

data-sync-user commented 10 months ago

➤ issozi commented:

Hi all, that option should be changed to “Payment Methods” as well. We’d missed that surface in our spreadsheet. FYI desktop details for that are here: https://mozilla-hub.atlassian.net/browse/FXA-8837 ( https://mozilla-hub.atlassian.net/browse/FXA-8837|smart-link ).

data-sync-user commented 10 months ago

➤ Roux Buciu commented:

issozi I’m happy to make that change, but I will note, we’re past string freeze dates now, so there’s no guarantees these will be translated for 122 anymore.

data-sync-user commented 10 months ago

➤ issozi commented:

Noted - thank you!

data-sync-user commented 10 months ago

➤ Roux Buciu commented:

it’ll be there for 123 for sure… and it’ll likely be there for the major languages for 122, but languages with less contributors may not get to it. There’s just no way to know, really, given that translation is volunteer run.

data-sync-user commented 10 months ago

➤ Diana Andreea Barladeanu commented:

Hi issozi and Roux Buciu So should I log a bug regarding this missing change to be sure that we don’t forget about it?

data-sync-user commented 10 months ago

➤ Roux Buciu commented:

No need. I’ll take care of it today. Thanks though.

data-sync-user commented 10 months ago

➤ Roux Buciu commented:

Ok, so I just looked and we don’t have this string in the application anymore (only in the OldStrings struct that’s, where strings that aren’t used but not yet delete go, so.... it's probably coming from a webview or AS.

data-sync-user commented 10 months ago

➤ issozi commented:

Hi Roux Buciu, if it comes from webview or AS, does that mean that whatever changes happen on desktop are automatically carried through without any further dev work required on the iOS side?

data-sync-user commented 10 months ago

➤ Roux Buciu commented:

Possibly. We’d have to track down exactly who handles those strings.

Looking at it close, that is an FxAccounts webview for sure, so yeah, AS, presumably.

data-sync-user commented 9 months ago

➤ Andrei Bodea commented:

Hello, we still have displayed Credit Cards on the account creation on v122 (37590) and I wanna close this bug, is that how it will remain, or should I set this bug to Open as it’s not fully fixed? I’ve checked the below comments but still can’t figure out what should we do with this issue.

data-sync-user commented 9 months ago

➤ Diana Andreea Barladeanu commented:

issozi Roux Buciu Giving the below comments, can we close this ticket as fixed or should we reopen it? Thanks!

data-sync-user commented 9 months ago

➤ issozi commented:

Diana Andreea Barladeanu Andrei Bodea I think we should wait until the change’s been made on the account creation page before closing this bug and closing this ticket as fixed.

data-sync-user commented 9 months ago

➤ Andrei Bodea commented:

Thank you issoziin this case we either set the status of the bug to Open, or set the fix version to 123, please notice this week is the release candidate week and we will release it together with this issue so in any case it will be verified in the future versions like v123.

data-sync-user commented 9 months ago

➤ Roux Buciu commented:

Given that this is an AS thing, is there an AS ticket for them to fix this, issozi? This ticket would merely be tracking the QA work needed for verifying that the work was done.

data-sync-user commented 9 months ago

➤ issozi commented:

Yes indeed Roux Buciu, I believe this one captures that: https://mozilla-hub.atlassian.net/browse/FXA-8837 ( https://mozilla-hub.atlassian.net/browse/FXA-8837|smart-link )

data-sync-user commented 9 months ago

➤ issozi commented:

Hi Roux Buciu, quick follow up question on these string changes - for the strings with the word “Firefox” specifically (i.e. rows 290, 295, 297 in the spreadsheet ( https://docs.google.com/spreadsheets/d/1Wof2_8o1PoVqbgJyxe7tdIn6qYBIcWlal3T9kJOhwK0/edit#gid=64342838 )) can you confirm that they were coded in such a way that the “Firefox” would not be translated/localized? A conversation with the Android team suggested that we ought to have written “%s” in place of “Firefox” in the new strings column to prevent localization of the word.

data-sync-user commented 9 months ago

➤ Norberto Andres Furlan commented:

Andrei Bodea just to make sure. Was this verified? I closed it, but let me know if there is something missing. Thanks!

data-sync-user commented 9 months ago

➤ Andrei Bodea commented:

Hello, Norberto Andres Furlansorry for the late response I was in PTO.

No, this issue was not verified that's why we agreed below to set it as Open because we still had that issue, for example I checked on our latest v123 (38163)(beta 4) and it’s not even there anymore I have only 4 options Bookmarks History Open Tabs Passwords.

What it can be see below here https://mozilla-hub.atlassian.net/browse/FXIOS-7663?focusedCommentId=819016 ( https://mozilla-hub.atlassian.net/browse/FXIOS-7663?focusedCommentId=819016|smart-link ) this is not in our app but on desktop side so that one was verified.

I believe we need to re-open this and see when it will be added to our app or what happened with it.

data-sync-user commented 9 months ago

➤ Roux Buciu commented:

issozi I 100% missed your question! I’m so sorry. Yes, anywhere the word Firefox appears in the app, we replace it with a placeholder so that it’s not translated, and the App name is inserted.

data-sync-user commented 9 months ago

➤ Norberto Andres Furlan commented:

Andrei Bodea For the FX account sign in page, I see the “Payment Methods” option (in beta and in 122.1). Please let me know if you still don’t see it, maybe it is a location issue. Thanks!

!IMG_5226.png|width=1179,height=2556!

data-sync-user commented 9 months ago

➤ Andrei Bodea commented:

Yes, this one was fixed. Verified as fixed on v123 (38491) and v122.1 with iPhone 15 Pro (17.1.2).