search

mozilla-mobile / firefox-ios

Firefox for iOS
Mozilla Public License 2.0
12.08k stars 2.88k forks source link

Handle view port in WebEngine #17998

Open data-sync-user opened 5 months ago

data-sync-user commented 5 months ago

┆Issue is synchronized with this Jira Task

data-sync-user commented 3 months ago

➤ Matthew Reagan commented:

{quote}The Client should not be responsible for zoom page bar{quote}

Laurie Marceau Do you have any more details on this? Do we want the WebEngine to provide the UI for the zoom page bar? (I had initially assumed clients would provide this, since the clients would also need to worry about things like theme and styling etc.)

data-sync-user commented 3 months ago

➤ Laurie Marceau commented:

Yes the Zoom page bar UI should be provided by the Client. In fact, any UI should be provided by the Client as I don’t think UI code should be done in WebEngine at all.

I used the wrong word there, it should’ve been

{quote}The WebEngine should not be responsible for zoom page bar{quote}

😬 I fixed it in the description.