search

mozilla-mobile / firefox-ios

Firefox for iOS
Mozilla Public License 2.0
12.2k stars 2.92k forks source link

Sync Issue After Sign-in, Fixing When Option is Toggled Off and syncing is Tiggered #18015

Open jnrahme opened 9 months ago

jnrahme commented 9 months ago

Steps to reproduce

Set up your debugger by navigating to the RustSyncManager class. Set breakpoints in the getEnginesAndKeys() function. Open the Firefox app. Click on the hamburger menu. Select "Sync and Save Data." Log in to your account. Toggle the switch for either address or credit cards to the "off" position. Close the settings, triggering background sync.

Expected behavior

When the toggle switch is in the "off" position, there should be no synchronization.

Actual behavior

Synchronization occurs every time the close button is clicked, syncing the last item toggled even though it is supposed to be turned off.

Device & build information

┆Issue is synchronized with this Jira Task

annie-gupta commented 9 months ago

Hi @jnrahme , Please assign this issue to me. Thank you.

lmarceau commented 9 months ago

@annie-gupta Hello! Thanks for wanting to contribute to the project. It's preferable for contributors to look at "Contributor OK" tasks, as we go over in contributing guildelines. Thanks!