mozilla-mobile / firefox-ios

Firefox for iOS
Mozilla Public License 2.0
12.23k stars 2.93k forks source link

PDF Jumps to Top when Scrolling Up #18436

Open SebastianRuan opened 9 months ago

SebastianRuan commented 9 months ago

Steps to reproduce

Open a pdf in Firefox on an iPhone 14. Scroll down several pages. Then scroll up so the url bar shows again and then release your finger.

Expected behavior

Scroll up a few centimetres.

Actual behavior

Jumps to beginning of pdf.

Device & build information

┆Issue is synchronized with this Jira Task

afurlan-firefox commented 9 months ago

Hi @SebastianRuan! Can you share a video or the website where you see this happening? I am not able to reproduce it. Thanks!

data-sync-user commented 9 months ago

➤ Norberto Andres Furlan commented:

Andrei Bodea can you try to reproduce it? Thanks!

jasonkelly214 commented 8 months ago

I have this issue as well and have had it for a long time. It is possibly related to seeing the browser navigation bar AND the pdf navigation bar. I couldn't get it to jump up to the top but it was doing it to me constantly yesterday. I'll try and turn on screen recording whenever I'm looking at pdfs to try and catch it.

Here's a screenshot showing the dual nav bars though.image

lmarceau commented 8 months ago

Hello @SebastianRuan! There was a fixed for this issue on https://github.com/mozilla-mobile/firefox-ios/issues/15184, which will be released in the version 124. Your screenshot here seems like a duplicate of this issue 🤔 Let us know if version 124 doesn't solve this problem when you get your hands on it 🙏

jasonkelly214 commented 8 months ago

Meant to upload this as well but it didn't go through. Seems to happen a lot when trying to select text too.

https://github.com/mozilla-mobile/firefox-ios/assets/21180839/6bcf4b2d-d32b-424d-bae4-39912430fd98

https://github.com/mozilla-mobile/firefox-ios/assets/21180839/926ac7ea-1591-426b-a7ad-ca83827a7194

https://github.com/mozilla-mobile/firefox-ios/assets/21180839/dabbae16-56e7-414f-911d-a2aa9eb4103a

TheProjectsGuy commented 8 months ago

I had a simiar problem using Firefox 121 on my 4th Gen iPad Air. Whenever I used to scroll up and lift my finger when in motion, the PDF used to jump to the top (first page). This also used to happen when zooming out sometimes. I updated to 123.1 and this issue no longer exists. Nice fix.

Prurite commented 8 months ago

Possibly related to https://github.com/mozilla-mobile/firefox-ios/issues/17146?

data-sync-user commented 8 months ago

➤ Sorin Paraipan commented:

I've tried several scenarios to reproduce this issue without success on v124. I think a fix has been implemented, as already mentioned by Laurie Marceau.

Prurite commented 8 months ago

➤ Sorin Paraipan commented:

I've tried several scenarios to reproduce this issue without success on v124. I think a fix has been implemented, as already mentioned by Laurie Marceau.

Reproducible in 123.1 (38978). Scroll back and forth a couple of times and it randomly jumps to the top.

https://github.com/mozilla-mobile/firefox-ios/assets/44775584/10a05022-9f11-4b17-9a34-e16475de9f36

And noticed a similar issue: calling out the dock also sends the page to top. Maybe I should open a new issue? Also, switching Firefox to background and back resets the pdf pos, while other pages pos are correctly remembered.

https://github.com/mozilla-mobile/firefox-ios/assets/44775584/d5e7a32e-8500-46ce-9e62-dadf25fe84d6

Prurite commented 8 months ago

And please also take a look at https://github.com/mozilla-mobile/firefox-ios/issues/17519 where opening a link in a pdf tab causes all pdf tabs to jump to that link. The pdf reader part of Firefox just look buggy.

data-sync-user commented 6 months ago

➤ Diana Andreea Barladeanu commented:

Verified as fixed on v9000 (41100), with iPhone 15 (17.4).

data-sync-user commented 5 months ago

➤ Diana Andreea Barladeanu commented:

Verified as fixed on v127 (41813), with iPhone 15 (17.4).