search

mozilla-mobile / firefox-ios

Firefox for iOS
Mozilla Public License 2.0
12.2k stars 2.92k forks source link

Remove autofilling of the form details without concent #18627

Open data-sync-user opened 8 months ago

data-sync-user commented 8 months ago

Remove autofilling of the form details In LoginsHelper.js

window.addEventListener("load", function(event) {
    observer.observe(document.body, { attributes: false, childList: true, characterData: false, subtree: true });
    for (var i = 0; i < document.forms.length; i++) {
      findLogins(document.forms[i]);
    }
  });

┆Issue is synchronized with this Jira Task

data-sync-user commented 7 months ago

➤ Nishant Bhasin commented:

As part of logins work this should already be done and merged in main branch so ready for v124 weekly

data-sync-user commented 7 months ago

➤ Alina Moldovan commented:

Nishant Bhasin could you please add some details for QA team?

nbhasin2 commented 7 months ago

Hi, here as long as a user taps to fullfill their password we are in the clear.

Basically we don't want the password to get autofilled without user tapping on their password in bottom sheet

Happy flow: Have password of a webpage saved Go to said webpage Tap on the password field Tap on password autofill button Check if the bottom sheet shows up If it does show up then use this to autofill the password field

data-sync-user commented 6 months ago

➤ Norberto Andres Furlan commented:

Nishant Bhasin what is the PR associated with this? I can’t find it. Is this something for the weekly release? I think we should put the version where this was released (if it was).

data-sync-user commented 6 months ago

➤ Nishant Bhasin commented:

PR: https://github.com/mozilla-mobile/firefox-ios/pull/18947 ( https://github.com/mozilla-mobile/firefox-ios/pull/18947|smart-link )

data-sync-user commented 6 months ago

➤ Nishant Bhasin commented:

PRs

https://github.com/mozilla-mobile/firefox-ios/pull/18947 ( https://github.com/mozilla-mobile/firefox-ios/pull/18947|smart-link )

https://github.com/mozilla-mobile/firefox-ios/pull/18879 ( https://github.com/mozilla-mobile/firefox-ios/pull/18879|smart-link )

data-sync-user commented 5 months ago

➤ Andrei Bodea commented:

Verified as fixed on v126 (41677) with iPhone 13 Pro (15.7.1).

Everything works as expected as mentioned here https://mozilla-hub.atlassian.net/browse/FXIOS-8400?focusedCommentId=852895 ( https://mozilla-hub.atlassian.net/browse/FXIOS-8400?focusedCommentId=852895|smart-link ) and the autofill was done without problems.