search

mozilla-mobile / firefox-ios

Firefox for iOS
Mozilla Public License 2.0
12.14k stars 2.91k forks source link

Desktop mode view on private mode affects regular mode #18723

Closed dragosb01 closed 6 days ago

dragosb01 commented 6 months ago

Steps to reproduce

  1. Open a website
  2. Switch to private browsing and open a website
  3. Tap 'Request Desktop Site' - The desktop version of the sites is loaded for private mode
  4. Open a tab in regular mode or run the automation test from notes

    Expected behavior

    The mobile version of the sites is loaded for private mode

    Actual behavior

    The desktop version of the sites is loaded for regular mode

    Device & build information

┆Issue is synchronized with this Jira Task

clarmso commented 5 months ago

I have taken a video of the test. The test website has been replaced with "https://www.youtube.com" for clarity. https://github.com/mozilla-mobile/firefox-ios/assets/1740517/34fafd7a-bc71-4d19-b5ed-046c097ec3ec

Note the following actual behaviour:

dragosb01 commented 5 months ago

I have taken a video of the test. The test website has been replaced with "https://www.youtube.com" for clarity. https://github.com/mozilla-mobile/firefox-ios/assets/1740517/34fafd7a-bc71-4d19-b5ed-046c097ec3ec

Note the following actual behaviour:

  • I can still toggle between desktop and mobile sites on the private tab.
  • When I tried to toggle back to private mode on the regular tab, the page refreshes to desktop mode.

i believe your video is more related to drag and drop rather than desktop and mobile, am i mistaken? There is definitely an issue there.

dragosb01 commented 6 days ago

Issue fixed