search

mozilla-mobile / firefox-ios

Firefox for iOS
Mozilla Public License 2.0
12.2k stars 2.92k forks source link

[Tab tray refactor] PB section is not selected in the tabs tray section when opening a website from the homepage while being in the PB #18743

Closed abodea closed 6 months ago

abodea commented 8 months ago

Steps to reproduce

  1. Launch FF and set PB from the homepage.
  2. Open any website.
  3. Access the tabs tray and observe if PB is selected at the top.

    Expected behavior

    PB should be selected in the tabs tray.

    Actual behavior

    PB section is not selected in the tabs tray section when opening a website from the homepage while being in the PB.

    Device & build information

https://github.com/mozilla-mobile/firefox-ios/assets/42831109/05321f0b-eeac-49b0-b51a-c3f88d6d3942

┆Issue is synchronized with this Jira Task

data-sync-user commented 7 months ago

➤ Sophie Amin commented:

Andrei Bodea Hey there, I think this might have been fixed in another pull request, can you test and confirm this isn’t happening anymore when you test? I checked the video and I could not reproduce, so I’m hoping it’s fixed 😀

data-sync-user commented 7 months ago

➤ Andrei Bodea commented:

Hello, Sophie Aminsure thing! This still with the experiment on, right?

data-sync-user commented 7 months ago

➤ Sophie Amin commented:

Andrei Bodea yes! I tested with the tab tray refactor enabled and couldn’t repro.

data-sync-user commented 7 months ago

➤ Dragos Bigu commented:

Sophie Amin this issue is reproducing on iPad. testCloseAllTabsPrivateModeUndo and testTabCountShowsOnlyNormalOrPrivateTabCount automation tests are failing due to this issue.

data-sync-user commented 7 months ago

➤ Alina Moldovan commented:

This issue still reproducers using v9000 (39865)

data-sync-user commented 6 months ago

➤ Diana Andreea Barladeanu commented:

Verified as fixed on v125 (40250), with iPhone 15 (17.0).