search

mozilla-mobile / firefox-ios

Firefox for iOS
Mozilla Public License 2.0
12.1k stars 2.88k forks source link

Remove Deferred from PasswordDetailViewController #18915

Open data-sync-user opened 4 months ago

data-sync-user commented 4 months ago

Prerequisite

This task can be tackled once the needed RustLogins functions have been added on the RustLogins class. See Deferred tasks here.

Context

RustLogins is used as part of the profile object in multiple places throughout the codebase. As a first step to remove Deferred, we can remove it from the high level production code, leaving us with an interface that doesn’t depend on this legacy object.

For this current task, this means adding a using the new completion handlers method added on the RustLogins object through the LoginsProtocol.

Acceptance criteria

Use the new methods on the LoginsProtocol so the PasswordDetailViewController class is not using Deferred anymore.

Contributor note

This a contributor task, if you plan on working on this ticket please write so as a comment under this task so others can know this is being worked on.

┆Issue is synchronized with this Jira Task

data-sync-user commented 3 months ago

➤ Orla Mitchell commented:

For QA please verify that everything around passwords in settings works correctly.

data-sync-user commented 3 months ago

➤ Andrei Bodea commented:

Hello, Orla Mitchell https://mozilla-hub.atlassian.net/browse/FXIOS-8747?focusedCommentId=860363&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-860363 ( https://mozilla-hub.atlassian.net/browse/FXIOS-8747?focusedCommentId=860363&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-860363|smart-link ) do you think this issue is related to this fix? The one I shared can be reproduced only by going to settings > Passwords section > multitask to device settings change the theme from dark to light or vice versa > multi-task to FF again (PWD section is displayed) > FF gets frozen and after 1 minute it crashes or a force close (at launch will crash).

data-sync-user commented 3 months ago

➤ Andrei Bodea commented:

Hi, Orla MitchellNorberto Andres Furlan as we still have this issue https://mozilla-hub.atlassian.net/browse/FXIOS-8975 ( https://mozilla-hub.atlassian.net/browse/FXIOS-8975|smart-link ) are those related? I’m not sure but I believe I can close this issue as there is the other one reported.

data-sync-user commented 2 months ago

➤ Alina Moldovan commented:

Marking it as verified as the related issue is logged separately