search

mozilla-mobile / firefox-ios

Firefox for iOS
Mozilla Public License 2.0
12.23k stars 2.94k forks source link

Update Fonts related to PhotoActionSheet to use FXFontStyles #18943

Open data-sync-user opened 8 months ago

data-sync-user commented 8 months ago

Please update how we set fonts in:

PhotoActionSheet PhotoActionSheetSiteHeaderView PhotoActionSheetTitleHeaderView

to use FXFontStyles instead of calling DefaultDynamicFontHelper directly. Provide before and after screenshots of the UI.

Usage example: FXFontStyles.Regular.headline.scaledFont()

┆Issue is synchronized with this Jira Task

imsanchit commented 8 months ago

hey, I was working on this task, the font corresponding to the font with text style: body, size: 17, and weight: bold is not there in FXFontStyles. Should this be added or mapped with some other font style in FXFontStyles

cyndichin commented 8 months ago

Thanks for checking! There are inconsistencies in the application and going forward our fonts should follow our design system, so we should use the Bold style for body in FXFontStyles. I will also have our designer verify the update fonts, so it would be helpful to add before and after screenshots to the PR.

cc: @cwzilla

cyndichin commented 8 months ago

@imsanchit just wanted to follow up, are you still interested in this task?

imsanchit commented 8 months ago

hey @cyndichin, I missed this comment. will be working on it and sharing the PR.

cyndichin commented 8 months ago

no worries @imsanchit - thank you for the contributions! :)

data-sync-user commented 7 months ago

➤ Cyndi Chin commented:

Please verify the fonts for in the latest build, thank you! See screenshots in PR.

data-sync-user commented 7 months ago

➤ Adina Petridean commented:

Verified as fixed on v9000(40522), with iPhone 14 Pro Max (16.2).

!SS.png|width=1733,height=558,alt="SS.png"!

data-sync-user commented 6 months ago

➤ Diana Andreea Barladeanu commented:

Validated on v127 (41813), with iPhone 15 (17.4).