Update Fonts in EmptyPrivateTabsView to use FXFontStyles

mozilla-mobile / firefox-ios

Firefox for iOS

Mozilla Public License 2.0

12.23k stars 2.94k forks source link

Update Fonts in EmptyPrivateTabsView to use FXFontStyles #18945

Open data-sync-user opened 8 months ago

data-sync-user commented 8 months ago

Please update how we set fonts in EmptyPrivateTabsView to use FXFontStyles instead of calling DefaultDynamicFontHelper directly. Provide before and after screenshots of the UI.

For example: FXFontStyles.Regular.headline.scaledFont()

┆Issue is synchronized with this Jira Task

data-sync-user commented 8 months ago

➤ Cyndi Chin commented:

This work has been merged in v125, please verify that the empty private tab views fonts are scaled properly. See PR associated with Github issue for screenshots.

data-sync-user commented 7 months ago

➤ Adina Petridean commented:

Verified as fixed on v9000(40522), with iPhone 14 Pro Max (16.2).

!PrivateBrowsing.png|width=1145,height=1005,alt="PrivateBrowsing.png"!

data-sync-user commented 6 months ago

➤ Diana Andreea Barladeanu commented:

Validated on v127 (41813), with iPhone 15 (17.4).