Update Fonts related to Onboarding to use FXFontStyles

mozilla-mobile / firefox-ios

Firefox for iOS

Mozilla Public License 2.0

12.2k stars 2.92k forks source link

Closed data-sync-user closed 7 months ago

data-sync-user commented 7 months ago

Please update how we set fonts in:

DefaultBrowserOnboardingViewController OnboardingInstructionPopupViewController

to use FXFontStyles instead of calling DefaultDynamicFontHelper directly. Please provide before and after screenshots of the UI.

If there are inconsistencies in size and weight, we will confirm with design if the changes are good once the PR is open.

Usage example: FXFontStyles.Regular.headline.scaledFont()

┆Issue is synchronized with this Jira Task

data-sync-user commented 7 months ago

➤ Cyndi Chin commented:

Please verify that fonts are scaled properly! Thank you.

See PR for screenshots.

data-sync-user commented 7 months ago

➤ Diana Andreea Barladeanu commented:

Validated on v9000 (39865), with iPhone 15 (17.0).

data-sync-user commented 7 months ago

➤ Alina Moldovan commented:

Validated this issue using v125(39935) and iPhone 14+ (16.0.3) please see the results bellow:

For the page opened form onboarding screen some differences are visible (Beta FF app is v125(39935) Versus FF app (v121.1))
For the page opened from Homepage banner I don't see any difference (Beta FF app is v125(39935) Versus FF app (v121.1))

Cyndi Chin Please advice.

!Skype_Video1.mp4|width=41.66666666666667%!

!Skype_Video2.mp4|width=41.66666666666667%!

data-sync-user commented 7 months ago

➤ Cyndi Chin commented:

Looks good from my side and also confirmed with Crystal Wong !

data-sync-user commented 7 months ago

➤ Alina Moldovan commented:

Thank you!