[Experiment] The Firefox Suggest results icons flicker while typing a keyword that triggers the same suggestions

mozilla-mobile / firefox-ios

Firefox for iOS

Mozilla Public License 2.0

12.14k stars 2.91k forks source link

[Experiment] The Firefox Suggest results icons flicker while typing a keyword that triggers the same suggestions #19044

Open data-sync-user opened 6 months ago

data-sync-user commented 6 months ago

[Affected versions]

Firefox Release 124 (39359)

[Affected platforms]

iPhone 13 mini, iOS 16.5

[Prerequisites]

Have the Firefox Suggest Sponsored and Non-Sponsored suggestions enabled.

[Steps to reproduce]

Open the Firefox build.
In the address bar type "houzz" keyword.
Tap on the “Houzz” sponsored result.
Focus the address bar and type “houzz” keyword.
Observe the Firefox Suggest results while typing the keyword.

[Expected results]

The Firefox Suggest results are displayed correctly without any flickers.

[Actual results]

The houzz results flicker while a letter is added or deleted from the keyword.

[Notes]

This issue is reproducible with any kind of results, history, bookmarks, non-sponsored, or sponsored.
Attached is a screen recording of the issue.

!Skype_Video.mp4|width=886,height=1920!

┆Issue is synchronized with this Jira Bug

data-sync-user commented 6 months ago

➤ Norberto Andres Furlan commented:

I am not sure if this is on Tif Tran or Sorin Paraipan . Can you take a look?

data-sync-user commented 6 months ago

➤ Sorin Paraipan commented:

It is happening because the data is reloaded, it was happening even before.

data-sync-user commented 6 months ago

➤ Tif Tran commented:

I took a poke at it, I don’t know my way around the non fx suggest pieces enough to find the root cause, but I agree with Sorin Paraipan , I think this was happening before sponsored suggestions were introduced. Setting the nimbus variable to disable fx suggest, still results in this behaviour.

data-sync-user commented 3 months ago

➤ Cyndi Chin commented:

I have added a bandaid fix to avoid reloading in areas where we are receiving the same search results. This causes the images to flicker less since we were loading search multiple times even if there was no change in data. The flicker should not occur as often now, but there might be some slight flickering.

In the future hope to clean up the code and maybe investigate into using diffable datasource. Along with this work, the logic in the view controller was also moved to the view model.

data-sync-user commented 3 months ago

➤ Cosmin Muntean commented:

I have verified this issue on the latest Firefox 9000 (42802) in iPhone 13 mini with iOS 17.4.1.

The issue can still be reproducible with the STR described in this bug. However, with other scenarios with multiple history, images seems to flicker less.
Also, while verifying this bug, I haven't encountered any other issues.

Considering this, I will mark this issue as verified.