search

mozilla-mobile / firefox-ios

Firefox for iOS
Mozilla Public License 2.0
12.2k stars 2.92k forks source link

Create RegularBrowserAddressToolbar #19088

Open data-sync-user opened 7 months ago

data-sync-user commented 7 months ago

Implements the toolbar UI for regular horizontal size classes. RegularBrowserAddressToolbar inherits from BrowserAddressToolbar.

┆Issue is synchronized with this Jira Task

data-sync-user commented 6 months ago

➤ Winnie Teichmann commented:

For QA: This can’t be tested only after the new toolbar is getting integrated into Firefox.

data-sync-user commented 2 months ago

➤ Alina Moldovan commented:

Winnie Teichmann, can you please add some details so the QA team knows what to test?

data-sync-user commented 2 months ago

➤ Winnie Teichmann commented:

Alina Moldovan the regular toolbar is displayed on iPhone in portrait mode.

data-sync-user commented 2 months ago

➤ Alina Moldovan commented:

The ticket was validated using v9000 (44362), iPhone 15+ (17.5.1), and iPad Pro 4th gen (17.2).

Confirming the regular view is displayed on iPhone in landscape mode and iPad (except for the case when stage manager is enabled and a reduced window dimension or in split view)

!Skype_Video2.mp4|width=41.66666666666667%,alt="Skype_Video2.mp4"!

!Skype_Video3.mp4|width=41.66666666666667%,alt="Skype_Video3.mp4"!

Winnie Teichmann found you please this is the intended behavior?

data-sync-user commented 2 months ago

➤ Winnie Teichmann commented:

Alina Moldovan yes, that looks correct.