search

mozilla-mobile / firefox-ios

Firefox for iOS
Mozilla Public License 2.0
12.12k stars 2.89k forks source link

Rearranging tabs by drag-and-drop rewrites tab contents on iOS 16 and 15 #19205

Open clarmso opened 5 months ago

clarmso commented 5 months ago

Steps to reproduce

Note: This issue isn't reproducible on iOS 17.x.

  1. Open a website (say www.wikipedia.org) on a tab.
  2. Open a new tab and open another website (say www.youtube.com).
  3. Open the tab tray.
  4. Long press the 2nd tab (www.youtube.com) until the context menu appears.
  5. Drag the 2nd tab to the left so that it becomes the 1st tab.

Expected behavior

First tab is www.youtube.com and the second tab is www.wikipedia.org.

Actual behavior

Both tabs are www.wikipedia.org.

Device & build information

The bug is shown only on iOS 16.4 and iOS 15.5. Both versions of iOS are supported currently.

The XCUITest DragAndDropTests.testRearrangeTabsTabTray() covers such a scenario.

Attachments:

Here are the screen recording of the behaviour from the same code base but different versions of iOS.

Screen recording on iPhone 15 iOS 17.2 simulator (expected behaviour): https://github.com/mozilla-mobile/firefox-ios/assets/1740517/f87bd92f-0cce-47cb-8dae-0fa15d5e8795

Screen recording on iPhone 14 iOS 16.4 simulator (bug :bug: ): https://github.com/mozilla-mobile/firefox-ios/assets/1740517/501cd650-0d79-40a1-8ded-fa94c82cd8fa

┆Issue is synchronized with this Jira Task

clarmso commented 5 months ago

Similar issue: https://github.com/mozilla-mobile/firefox-ios/issues/18724

data-sync-user commented 4 months ago

➤ Norberto Andres Furlan commented:

Sophie Amin can I put this for 125?

data-sync-user commented 3 months ago

➤ Diana Andreea Barladeanu commented:

Verified as fixed on v9000 (41731), with iPhone SE (16.6).

!Video-2.mov|width=272,height=480,alt="Video-2.mov"!

data-sync-user commented 2 months ago

➤ Diana Andreea Barladeanu commented:

Verified as fixed on v126.1 (41973), with iPhone 15 (17.4).