mozilla-mobile / firefox-ios

Firefox for iOS
Mozilla Public License 2.0
12.13k stars 2.9k forks source link

Update Fonts related to Component Library components to use FXFontStyles #19243

Open data-sync-user opened 5 months ago

data-sync-user commented 5 months ago

This task is part of a series of tasks to standardizing fonts to start using FXFontStyles.

Background Context: Previously, we were using DefaultDynamicFontHelper and setting the text style, size and weight for each font, which sometimes did not match our design system. By using FXFontStyles, we can standardize our fonts and be more aligned with the design system.

Task: Please update how we set fonts in our components in the Component Library:

LinkButton SecondaryRoundedButton ActionButton CollapsibleCardView

Acceptance Criteria:

Reference:

Usage example: FXFontStyles.Regular.headline.scaledFont()

See this PR for example of standardizing fonts for Primary Button:

https://github.com/mozilla-mobile/firefox-ios/pull/18711/files

┆Issue is synchronized with this Jira Task

bmihai23 commented 5 months ago

Hi @cyndichin, I would like to work on this issue. Thank you 🙏

data-sync-user commented 5 months ago

➤ Cyndi Chin commented:

Please verify the fonts and they scaled appropriately. See screenshots attached to Github PR to see which areas were changed.

data-sync-user commented 4 months ago

➤ Diana Andreea Barladeanu commented:

Verified on v126 (41093), with iPhone 15 (17.4).

Hi Cyndi Chin , “customise homepage” and “settings” from review checker have bold fonts and in the PR screenshots they do not.

Please advise. Thanks!

!43A32BAF-7862-47C7-A4BA-8D34CDB342D1.jpg|width=944,height=2048,alt="43A32BAF-7862-47C7-A4BA-8D34CDB342D1.jpg"!

!167A5C5F-B5B4-404F-B32D-4F29BAEB723B.jpg|width=944,height=2048,alt="167A5C5F-B5B4-404F-B32D-4F29BAEB723B.jpg"!

data-sync-user commented 3 months ago

➤ Cyndi Chin commented:

Crystal Wong Can you confirm if the screenshot updates below look good? Thank you!

data-sync-user commented 3 months ago

➤ Crystal Wong commented:

Cyndi Chin Diana Andreea Barladeanu Looks good! Thank you.

data-sync-user commented 3 months ago

➤ Alina Moldovan commented:

Closing ticket based on the previous comment