Update Fonts in SnackButton to use FXFontStyles

data-sync-user commented 6 months ago

This task is part of a series of tasks to standardizing fonts to start using FXFontStyles.

Background Context: Previously, we were using DefaultDynamicFontHelper and setting the text style, size and weight for each font, which sometimes did not match our design system. By using FXFontStyles, we can standardize our fonts and be more aligned with the design system.

Task: Please update how we set fonts in

SnackButton

Acceptance Criteria:

Replace usage of DefaultDynamicFontHelper with FXFontStyles
If there are discrepancies in terms of replacing the old fonts with the new standard, we will need to bring design in to approve the PR.
Please provide before and after screenshots of the UI.

Reference:

Usage example: FXFontStyles.Regular.headline.scaledFont()

See this PR for example of standardizing fonts for Primary Button:

https://github.com/mozilla-mobile/firefox-ios/pull/18711/files

┆Issue is synchronized with this Jira Task

rojinpra7 commented 6 months ago

i would like to work on this issue.

cyndichin commented 6 months ago

Hi @rojinpra7, thank you for your interest! This issue has already been addressed and is in review for QA. How about taking on this similar task instead? https://github.com/mozilla-mobile/firefox-ios/issues/19318

rojinpra7 commented 6 months ago

Sure. I would like to work on #19318

data-sync-user commented 5 months ago

➤ Adina Petridean commented:

Verified as fixed on v9000(40720), with iPhone 14 Pro Max (16.2).

!Screenshot 2024-04-12 at 14.21.23.png|width=1727,height=544,alt="Screenshot 2024-04-12 at 14.21.23.png"!

data-sync-user commented 4 months ago

➤ Diana Andreea Barladeanu commented:

Validated on v127 (41813), with iPhone 15 (17.4).

mozilla-mobile / firefox-ios

Update Fonts in SnackButton to use FXFontStyles #19248