search

mozilla-mobile / firefox-ios

Firefox for iOS
Mozilla Public License 2.0
12.15k stars 2.91k forks source link

Night mode missing in 124 #19365

Closed jryans closed 5 months ago

jryans commented 6 months ago

Steps to reproduce

  1. Look for night mode in the menu

Expected behavior

It should be there so I can control content night mode as I have for years…

Actual behavior

No night mode option :sob:

Device & build information

I am very concerned by issues I am seeing that suggest you are experimenting with removing the separate night mode switch. I have used it every day, and it is currently missing… If you remove it for real I will have to find a new browser so I can use my phone at night… :sob:

┆Issue is synchronized with this Jira Task

kelimuttu commented 6 months ago

Someone brought this up on SUMO just recently.

machinshin commented 6 months ago

I also noticed this last night

Firefox 124.0 (39709) On iPhone 14 Plus

iOS version: 17.3.1

MarkTheUnruly commented 6 months ago

I suffer from Diabetic Retinopathy and hence photophobia. To me, this removal is an Accessability issue. Dark Mode system theme doesn't work on most websites, including this one.

I also don't appreciate being treated like a lab rat. I love Firefox and use it across all my devices and PCs, but like others, I will move aweay from it if this isn't re-enabled.

Mozilla website says "Accessibility is a fundamental part of Mozilla’s mission to ensure the internet is "open and accessible to all" and it is one of our key Diversity, Equity & Inclusion pillars at the Mozilla Foundation." Well, right now it's failing that mission.

EDIT, I found this on SUMO:

From Kiki

It seems that we have high number of votes on this thread. For others that are using this feature pretty significantly, I highly encourage you to share feedback about why this feature is important to you.

The team is currently doing an experiment. Since March 15, 50% of users no longer see Night Mode switch from the hamburger menu. We're using this experiment to monitor and evaluate the impact of removing, so it'll be hugely valuable to hear your feedback around this feature. Thanks!

I don't appreciate being treated like a lab rat.

Zumbas commented 6 months ago

+1 Unbelievable how such a thing can happen. Let’s move to Brave! https://brave.com

Heryold commented 6 months ago

Please bring it back devs. Most pages are now displaying in light theme even if iOS is set to Dark Mode. It is really draining for the eyes.

Several people have reported this on Mozilla Support and Reddit as well:

https://support.mozilla.org/en-US/questions/1443100 https://support.mozilla.org/en-US/questions/1443002 https://support.mozilla.org/en-US/questions/1442900 https://support.mozilla.org/en-US/questions/1442772 https://www.reddit.com/r/firefox/comments/1bmjqun/firefox_ios_night_mode_is_gone/

kelimuttu commented 6 months ago

Another accessibility concern. This one is from SUMO:

I, too depend on night mode to do my job as a videographer. Lack of this feature renders your browser inaccessible and unusable for my sensory disability, as well. Last night it disappeared from the menus in my iPad and Android phone. Setting the theme to dark mode in iOS does not darken webpages.

crawford commented 6 months ago

We're using this experiment to monitor and evaluate the impact of removing, so it'll be hugely valuable to hear your feedback around this feature.

I’m not sure how the team is monitoring the impact of removing, so I guess I’ll just pile on here. Without Night Mode, the browser is unusable in the early morning and night, since most websites I visit do not respect the system theme. This is compounded by the fact that Firefox on iOS does not support extensions (i.e. Dark Reader cannot be installed). I have a strong preference towards using websites instead of apps, so this regression is particularly jarring. I’ll add to the sentiment expressed above, I do not appreciate being a part of this experiment and this only further encourages me to stop updating the apps on my phone.

brixtonn commented 6 months ago

this feature is the only reason i used firefox. since it no longer works i've uninstalled the app.

MarkTheUnruly commented 6 months ago

Interesting that there is no one assigned to this. Do I assume from that that the Firefox team doesn't care?

crawford commented 6 months ago

@MarkTheUnruly they are currently running an experiment via Nimbus (here’s the pull request which introduced it: https://github.com/mozilla-mobile/firefox-ios/pull/18803) and are waiting to hear users’ responses (I’m not sure how that feedback is gathered or monitored). In the meantime, I can’t imagine they would consider this a bug.

crawford commented 6 months ago

Here's the workaround for anyone who's interested.

Navigate to Menu > Settings > About and tap on "Firefox \<version number>" five times. That will open up a hidden Debug section. From there go to Debug > Experiments > iOS - Night Mode and select "control" instead of "treatment-a". That will bring back the "Turn on Night Mode" menu item.

I pulled this from https://support.mozilla.org/en-US/questions/1443105#answer-1644537. Thanks TimmyTango.

MarkTheUnruly commented 6 months ago

So, they removed an accessibility feature WITHOUT WARNING. What an utter lack of porfessionalism. I have been a coder since 1985 and I would never do what they have done.

I am a diabetic with vision issues. A dark background is a requirement for me to use a device without strain and most websites don't support a dark mode, (including support.mozilla.org). This will affect everyone with cataracts, photophobia and various other conditions. Having diabetes makes you 2 to 5 times more likely to develop cataracts. It also makes you more likely to get them at a younger age. This means that the number of people is growing along with the rise in Type 2 diabetes.

One of Firefox's missions is supposed to be to make the web more accessible to people. I dont have night mode, so for me, Firefox for IOS is currently failing that misssion.

Removing this feature would force me to switch browsers on my iPad, probably to Safari (which I hate), so I can use the Dark Reader add-in. I have been using Firefox since 2004 when the committee advising the US government said IE6 was a security concern and I love the features and ease of use.

MarkTheUnruly commented 6 months ago

Here's the workaround for anyone who's interested.

Navigate to Menu > Settings > About and tap on "Firefox " five times. That will open up a hidden Debug section. From there go to Debug > Experiments > iOS - Night Mode and select "control" instead of "treatment-a". That will bring back the "Turn on Night Mode" menu item.

I pulled this from https://support.mozilla.org/en-US/questions/1443105#answer-1644537. Thanks TimmyTango.

Thank you!

crawford commented 6 months ago

So, they removed an accessability feature WITHOUT WARNING. What an utter lack of porfessionalism.

-Admin removed personal details which violate Mozilla's guidelines-

MarkTheUnruly commented 6 months ago

-Admin removed personal details which violate Mozilla's guidelines-

@crawford, I thoroughly agree!

jevans-mozilla commented 5 months ago

Please do not let conversations devolve into personal attacks. Feeling strongly about a topic is acceptable. Feedback on topics is acceptable. Personal attacks on individuals is not.

MarkTheUnruly commented 5 months ago

Please do not let conversations devolve into personal attacks. Feeling strongly about a topic is acceptable. Feedback on topics is acceptable. Personal attacks on individuals is not.

Jeremy, fair comment, but if a person has broken professional rules in their country of residence, should they not be held accountable for their actions?

data-sync-user commented 5 months ago

➤ Norberto Andres Furlan commented:

Thank you for taking the time to share your concerns and feedback. We truly understand the importance of accessibility features and your feedback is really valuable for us. We apologize for any inconvenience caused by the experiment.

In response to the feedback collected, I have requested the termination of the experiment. The nightmode option will be reinstated soon. Please feel free to reach out to us if you have any further questions or concerns.

cdaylward commented 5 months ago

➤ Norberto Andres Furlan commented:

Thank you for taking the time to share your concerns and feedback. We truly understand the importance of accessibility features and your feedback is really valuable for us. We apologize for any inconvenience caused by the experiment.

In response to the feedback collected, I have requested the termination of the experiment. The nightmode option will be reinstated soon. Please feel free to reach out to us if you have any further questions or concerns.

Friendly note: Perhaps check in a code comment or other documentation that this is an important accessibility and usability feature so that future devs do not venture down this route?

Needless to say that browsers are now an important part of modern life. It might be good to have a reminder that it's not all just a matter of aesthetics (or even developer burden).

ironlion37 commented 5 months ago

Yes, this is the main reason I use the app on my phone. There's room for major improvements here though:

  1. Tie the dark mode to system settings on the phones. In other words, if my iPhone is set to use dark mode, give me the option in Firefox settings to "use system setting."
  2. Dark mode should work as the "Dark Reader" browser extension does. (If there was a way to get than on my phone browser, I would do it.) Firefox dark mode doesn't work really well - some sites I want to turn it on, some site I need to turn it off. The Dark Reader extension is very good about handling all that gracefully and automatically. I suggest studying how that piece of software does its thing.
MarkTheUnruly commented 5 months ago

Ok, apparently the experiment is being terminated and night mode re-instated, good news.

jevans-mozilla commented 5 months ago

Please do not let conversations devolve into personal attacks. Feeling strongly about a topic is acceptable. Feedback on topics is acceptable. Personal attacks on individuals is not.

Jeremy, fair comment, but if a person has broken professional rules in their country of residence, should they not be held accountable for their actions?

Mozilla complies with professional titles for job positions in Canada as it varies between province of residence. In this case no professional rules were broken.

We do enforce our Code of Conduct here and posting personal information about an employee is not only in breach of our code of conduct, but also in bad taste.

If you feel anyone (especially Mozilla employees) are acting unprofessionally, there is a means to submit a concern at the bottom of the above link.

ironlion37 commented 5 months ago

An update: I just found out that the Dark Reader browser extension can be downloaded and used with Safari on iOS. So I've now switched to Safari as my default browser on my phone as well. Dark mode is a main requirement for me in a browser.

As I mentioned above Dark Reader handles sites much more gracefully than Firefox dark mode.

If Firefox could load the dark reader extension as Safari does, then I would switch back to Safari.