search

mozilla-mobile / firefox-ios

Firefox for iOS
Mozilla Public License 2.0
12.14k stars 2.91k forks source link

Swiftlint: discouraged_assert #19592

Open data-sync-user opened 5 months ago

data-sync-user commented 5 months ago

"In order to bring Focus iOS up to the same Swiftlint standard as Firefox iOS, we must iteratively update the swiftlint file for Focus, found in firefox-ios/focus-ios/.swiftlint.yaml. Note that each rule must be enabled separately, the warnings fixed, and then a PR made. It may be possible that, once a rule is enabled, no warnings for it appear. Final note: because of the BitRise setup, you must check for warnings in Focuse by running swiftlint from the command line from the focus folder OR from within Xcode with the Focus project open, given that you have Swiftlint installed on your system."

┆Issue is synchronized with this Jira Task

data-sync-user commented 4 months ago

➤ Diana Andreea Barladeanu commented:

Hi Roux Buciu What should QA validate here? Thanks!

data-sync-user commented 4 months ago

➤ Roux Buciu commented:

This should have been put in Done not QA needed. There’s no QA needed for this. 🙂