search

mozilla-mobile / firefox-ios

Firefox for iOS
Mozilla Public License 2.0
12.14k stars 2.91k forks source link

Cleanup: update SampleBrowser as needed for UUID-based theme manager #19687

Open data-sync-user opened 5 months ago

data-sync-user commented 5 months ago

Related PR: https://github.com/mozilla-mobile/firefox-ios/pull/19684

┆Issue is synchronized with this Jira Task

data-sync-user commented 5 months ago

➤ Matt Reagan commented:

cc Winnie Teichmann I will probably revisit this soon to figure out exactly how it should work, if anything is blocking you in the meantime please LMK.

data-sync-user commented 4 months ago

➤ Matt Reagan commented:

I took another look at this but I don’t believe there are any changes needed here for the time being. In the SampleBrowser the UUID for now is generated by the SceneDelegate and injected into the RootViewController, which is the only place I can see at a glance where we need the UUID in order to apply themeing.

Winnie Teichmann Let me know if there is anything I might have overlooked (e.g. toolbar-related) that could require refactors or updates as part of the multi-window / themeing refactors.