mozilla-mobile / firefox-ios

Firefox for iOS
Mozilla Public License 2.0
12.09k stars 2.88k forks source link

[Customization onboarding] - "Show tour" always displays the default card options (not the actual settings) #19715

Open DianaABarladeanu opened 3 months ago

DianaABarladeanu commented 3 months ago

Prerequisites User is enrolled in "App Customization in Onboarding" experiment on treatment a.

Steps to reproduce

  1. Fresh install FF. Light theme is set from iOS settings.
  2. From FF settings, go to Show tour.
  3. Go to the 3rd card ("Pick a theme") and select dark theme, tap save and continue and exit onboarding tour. Dark theme is applied.
  4. Go back to "Show tour" and observe the theming card display.

Expected behavior Dark option is checkmarked as per previous setting.

Actual behavior "System auto" option (default) is checkmarked.

Device & build information

Notes This issue also applies to the toolbar placement card, the default state is displayed, not the actual one, no matter the customization.

Attachments:

https://github.com/mozilla-mobile/firefox-ios/assets/151131988/ba7094bc-2347-488c-a6b9-8b5a8081efc5

┆Issue is synchronized with this Jira Task

data-sync-user commented 2 months ago

➤ Norberto Andres Furlan commented:

Expected behavior for the MVP. We don’t have a theme preview for now, so if you select an theme option it will apply it.

We will evaluate this in case we release to a broader population.