search

mozilla-mobile / firefox-ios

Firefox for iOS
Mozilla Public License 2.0
12.09k stars 2.88k forks source link

Cleanup: update SampleComponentLibrary for UUID-based theme manager #19738

Open data-sync-user opened 3 months ago

data-sync-user commented 3 months ago

┆Issue is synchronized with this Jira Task

data-sync-user commented 1 month ago

➤ Matt Reagan commented:

Cyndi Chin Do you recall the specific action items for this? For the Component Library it looks like you added defaultSampleComponentUUID and some related extensions in 19740 ( https://github.com/mozilla-mobile/firefox-ios/pull/19740 ), which seems like a good solution to me. The only reason I can think of that we would need to refactor that is if we thought the component library might utilize multiple windows, but that seems unlikely. I’m going to close for now but please feel free to reopen or LMK if there is anything else that may need to be updated in the component library for MW.

data-sync-user commented 1 month ago

➤ Cyndi Chin commented:

Matt Reagan Nothing from my side, we can revisit if we do need to support multiple windows, but given that its used to demonstrate isolated UI components, I don’t see a likely use case either. Sounds good to close, thanks Matt!