mozilla-mobile / firefox-ios

Firefox for iOS
Mozilla Public License 2.0
12.08k stars 2.88k forks source link

Theming Issues - Website Dark Theme Support #19761

Open data-sync-user opened 2 months ago

data-sync-user commented 2 months ago

I have noticed so inconsistencies on how we display the sites based on the theme (dark or light). Also, I have noticed that for example in Safari and Google Chrome, google is always displayed in dark when the app is in dark theme, but in Firefox, we usually display it in white.

I want to understand what are we doing differently from the other apps. For example, see attached screenshots Sometimes google search will appear on white, but sometimes it will appear on dark (In both cases the app is in Dark Mode)

Expected Behavior:

Current Behavior:

!IMG_6027.PNG|width=25%,alt="IMG_6027.PNG"!

!IMG_6026.PNG|width=25%,alt="IMG_6026.PNG"!

┆Issue is synchronized with this Jira Spike

data-sync-user commented 1 month ago

➤ Matt Reagan commented:

{quote}Also, I have noticed that for example in Safari and Google Chrome, google is always displayed in dark when the app is in dark theme, but in Firefox, we usually display it in white. I want to understand what are we doing differently from the other apps.{quote}

Norberto Andres Furlan I haven’t actually been able to observe this in Safari so far. For example I attached 3 screenshots, the first was me opening an existing Google tab in Safari while the app was in light mode (in this case the tab was displayed in dark mode, but that didn’t match Safari which was in light mode).

I then explicitly set my phone’s theme to Dark and opened a new google tab (also tried reloading it a few times) in Safari and the Google website remained in light mode despite Safari’s UI being dark to match the iOS system setting.

I’m still investigating but so far I’m observing inconsistencies not just in Firefox but also in Safari.

!IMG_7533.PNG|width=1125,height=2436,alt="IMG_7533.PNG"!

!IMG_7534.PNG|width=1125,height=2436,alt="IMG_7534.PNG"!

!IMG_7532.PNG|width=1125,height=2436,alt="IMG_7532.PNG"!

data-sync-user commented 1 month ago

➤ Matt Reagan commented:

A few additional notes:

cc Norberto Andres Furlan LMK if you may want to discuss this further.