mozilla-mobile / firefox-ios

Firefox for iOS
Mozilla Public License 2.0
12.21k stars 2.93k forks source link

[UI] Privacy Policy link should open in a new tab. #19819

Open data-sync-user opened 6 months ago

data-sync-user commented 6 months ago

Clicking “privacy policy” should open the privacy policy URL in a new tab (consistent with Review Checker). The open survey should close/minimize upon navigation. It will still be visible at the bottom of the screen.

Privacy Policy should be able to handle localization as well.

┆Issue is synchronized with this Jira Task

data-sync-user commented 5 months ago

➤ Cyndi Chin commented:

Add to our Support Utils to send our users to a certain privacy policy link depending on locale. See Android ( https://searchfox.org/mozilla-central/source/mobile/android/fenix/app/src/main/java/org/mozilla/fenix/settings/SupportUtils.kt ).

Need to confirm whether we want to capture tracking via utm params.

data-sync-user commented 4 months ago

➤ Cyndi Chin commented:

Updated requirements: For the homepage, this should be the example of utm parameters: https://www.mozilla.org/en-US/privacy/firefox/?utm_medium=firefox-mobile&utm_source=modal&utm_campaign=microsurvey&utm_content=homepage ( https://www.mozilla.org/en-US/privacy/firefox/?utm_medium=firefox-mobile&utm_source=modal&utm_campaign=microsurvey&utm_content=homepage|smart-link ) Content utm param can be optional if not provided in experiment recipe.

data-sync-user commented 4 months ago

➤ Cyndi Chin commented:

Code merged in v129

data-sync-user commented 4 months ago

➤ Cyndi Chin commented:

For QA, please verify the following:

data-sync-user commented 2 months ago

➤ Alina Moldovan commented:

Validated as fixed on v130 (44311) and iPhone 15+ (17.5.1)