data-sync-user
commented
6 months ago ➤ Matt Reagan commented:
This will likely require additional UX discussion post-MVP. I’ve listed each widget action below and the changes (if any) I’m planning to make, and what the resulting behavior will be for multi-window. If anyone has questions or wants to chat further please let me know. Norberto Andres Furlan Nicole Weber Jeremy Evans Thank you
-
Close Private Tabs
- Plan is to update this so that it applies to all open windows (the current code will only close private tabs in one window,)
-
Quick View
-
Currently as-is this widget will only show open tabs for one window (and which window might change randomly if >1 are open). Updating it to save tabs across all windows is not difficult, the problem is that from a UX perspective the current widget UI doesn’t always make sense for MW.
- For example if you have 2 separate windows open and have http://google.com ( http://google.com|smart-link ) open in each, the widget would show two instances of google, and if you tap one, it’s not clear to the user which window will open.
-
Ideally what we’d probably want to do is update the widget UI to list the tabs in sections based on some kind of window number, but this is likely out of scope for the MVP (it would require changing the model that we save in prefs, and related widget UI, which is not hard but would require some UI/UX feedback).
-
Current plan for this widget is to update the existing code to save tabs for all windows (ordering is TBD). If possible I’ll be trying to fix the related route handling so that tapping on a tab in the widget ensures it always opens the associated window. I’m not planning to update the widget UI for the MVP, however please let me know if anyone thinks that should be prioritized.
-
See also: preserveTabs in TabManagerImplementation and SimpleTab.convertToSimpleTabs(windowData.tabData)
-
-
Search in Firefox & Search in Private Tab
- Leaving as-is for multi-window; iOS will determine which window receives the event (if multiple windows, one will be opened with the search field active, which one is up to the OS, though we can revisit other options here if we want)
-
Go to Copied Link
- Leaving as-is; for multi-window, iOS will determine which window receives the URL when tapped
-
Top Sites
- Same as above
- May need add’tl investigation as to how we’re calculating top sites to ensure it’s taking all windows into consideration but any potential issues with this should be an edge case (see also: TopSitesProvider / TopSitesWidget)
This task is to track updates to our widget actions will be necessary for the multi-window MVP. Aspects of this are TBD and may require additional team discussion before/after the multi-window release.
Currently the action items identified for MVP are:
(More details on the above in comments)
Github Issue: https://github.com/mozilla-mobile/firefox-ios/issues/20011
!Screenshot 2024-04-25 at 2.07.36 PM.png|width=311,height=146,alt="Screenshot 2024-04-25 at 2.07.36 PM.png"!
┆Issue is synchronized with this Jira Task