search

mozilla-mobile / firefox-ios

Firefox for iOS
Mozilla Public License 2.0
12.08k stars 2.88k forks source link

Remove Pocket Share Experiment #20145

Open data-sync-user opened 2 months ago

data-sync-user commented 2 months ago

This experiment has been disabled for a long time now and the experiment concluded there was no evidence for improvements.

Removing it to clean up the codebase.

https://docs.google.com/document/d/1AZY6dkG6OYBU-w7YYdkBtwnsPiGaOHlCZP2BqzQG_pQ/edit#heading=h.kzffe2a93ndd

┆Issue is synchronized with this Jira Task

data-sync-user commented 1 month ago

➤ Alina Moldovan commented:

Sophie Amin Could you please add some details for the QA team to know what to test?

data-sync-user commented 1 month ago

➤ Sophie Amin commented:

Alina Moldovan You can see the linked document for details one what the experiment was.

I removed the share icon in the toolbar when the experiment was enabled (so check toolbar/url bar function)

And the long press context menu options have been reverted back to their original state from before this experiment.

Send to device should only be available from the hamburger menu now.

Here’s the PR with additional details https://github.com/mozilla-mobile/firefox-ios/pull/20173#pullrequestreview-2048188316 ( https://github.com/mozilla-mobile/firefox-ios/pull/20173#pullrequestreview-2048188316|smart-link )

!simulator_screenshot_3F3EEEA7-7016-4727-84E4-DE24A42F88B6.png|width=1179,height=2556,alt="simulator_screenshot_3F3EEEA7-7016-4727-84E4-DE24A42F88B6.png"!

data-sync-user commented 1 month ago

➤ Donal Meehan commented:

This is currently planned to ship with 126.2

data-sync-user commented 1 month ago

➤ Diana Andreea Barladeanu commented:

Validated on v9000 (42224), with iPhone 15 (17.4.1).

I confirm that “share“b utton is available only from hamburger menu.

data-sync-user commented 1 month ago

➤ Diana Andreea Barladeanu commented:

Validated on v126.2 (42205), with iPhone 15 (17.4)