search

mozilla-mobile / firefox-ios

Firefox for iOS
Mozilla Public License 2.0
12.1k stars 2.88k forks source link

[Address Autofill] - CA - homedepot.ca - autofill is not working for all fields #20263

Open alinamoldovan84 opened 2 months ago

alinamoldovan84 commented 2 months ago

Steps to reproduce

  1. Make sure you are using a CA VPN connection
  2. Open homedepot.ca and Navigate to the Address form
  3. Tap on any of the address's fields
  4. Tap 'Use Saved address'
  5. Tap to select an address on the list

Expected behavior

All fields are autocompleted

Actual behavior

Address fields are not autofilled

Device & build information

https://github.com/mozilla-mobile/firefox-ios/assets/124251579/9ecc86e2-1e52-4773-87f1-47b770a0e9c2

┆Issue is synchronized with this Jira Task

nbhasin2 commented 2 months ago

@alinamoldovan84 does this work on homedepot US website and doesn't work on CA?

data-sync-user commented 1 month ago

➤ Norberto Andres Furlan commented:

Issam Mani can you take a look to this one?

data-sync-user commented 1 month ago

➤ Issam Mani commented:

Norberto Andres Furlan Daniel Dervishi missed this sorry. But I think this was partially covered in https://mozilla-hub.atlassian.net/browse/FXIOS-8771?focusedCommentId=864808 ( https://mozilla-hub.atlassian.net/browse/FXIOS-8771?focusedCommentId=864808|smart-link ) I commented there on why this doesn’t work as expected. Nothing we can do from iOS side. The fix will touch on heuristics and we still haven’t found a good fix for this. Can we mark it as blocked ?

data-sync-user commented 1 month ago

➤ Daniel Dervishi commented:

Issam Mani Thanks for leaving this comment! I thought that the issue might have been with the way the forms were laid out on homedepot.ca ( http://homedepot.ca ) and how we parse the website to determine what fields can be autofilled. I was just about to send out a slack message to ask who which team I can alert about this. Would you happen to know which team is responsible for this functionality?

data-sync-user commented 1 month ago

➤ Issam Mani commented:

Daniel Dervishi yes that would be me and the credential-management team 😄 I will file a bug on Desktop to look into the heuristics part of this. But the problem is two parts:

The form layout that homedepot uses breaks on Desktop too. Here is a reduced test case ( https://codepen.io/issammani/pen/MWdVXXm ) if you want to test locally on desktop.

I will file a bug on Desktop and mark this as blocked by it. What do you think ?

data-sync-user commented 1 week ago

➤ Daniel Dervishi commented:

Issue is blocked as per Issam Mani 's last comment. Will be moving the ticket to the todo category as a result