Open data-sync-user opened 3 months ago
➤ Adina Petridean commented:
Daniel Dervishi could you please pinpoint some before-and-after screenshots?
➤ Daniel Dervishi commented:
Testing Instructions: Open the application, navigate to a tab other than the home page and long press on the back button
Before:
!Screenshot 2024-06-05 at 11.07.07 AM.png|width=381,height=767,alt="Screenshot 2024-06-05 at 11.07.07 AM.png"!
After:
!Screenshot 2024-06-05 at 11.08.17 AM.png|width=355,height=768,alt="Screenshot 2024-06-05 at 11.08.17 AM.png"!
➤ Adina Petridean commented:
Verified as fixed on v9000(42550), with iPhone 14 Pro Max (16.2).
!Screenshot 2024-06-07 at 11.26.53.png|width=1019,height=998,alt="Screenshot 2024-06-07 at 11.26.53.png"!
➤ Adina Petridean commented:
Verified as fixed on Firefox 128.0 (42711), with iPhone 14 Pro Max (16.2).
This task is part of a series of tasks to standardizing fonts to start using FXFontStyles.
Background Context: Previously, we were using
DefaultDynamicFontHelper
and setting the text style, size and weight for each font, which sometimes did not match our design system. By usingFXFontStyles
, we can standardize our fonts and be more aligned with the design system.Task: Please update how we set fonts in the Firefox iOS Project related:
BackForwardTableViewCell
Acceptance Criteria:
Replace usage of
DefaultDynamicFontHelper
withFXFontStyles
If there are discrepancies in terms of replacing the old fonts with the new standard, we will need to bring design in to approve the PR.
Please provide before and after screenshots of the UI.
Reference:
Usage example:
FXFontStyles.Regular.headline.scaledFont()
See this PR for example of standardizing fonts for Primary Button:
https://github.com/mozilla-mobile/firefox-ios/pull/18711/files
┆Issue is synchronized with this Jira Task