search

mozilla-mobile / firefox-ios

Firefox for iOS
Mozilla Public License 2.0
12.23k stars 2.94k forks source link

Changing theme setting does not apply correctly to all iPad windows #20332

Open data-sync-user opened 6 months ago

data-sync-user commented 6 months ago

Steps:

  1. Open multiple windows, ensure you in a normal (non-private) tab
  2. Open Settings, set Theme to manual and switch between Dark/Light

Expected: the theme change applies to all windows and all UI is updated.

Actual: only the window where the setting was changed is updated.

┆Issue is synchronized with this Jira Bug

data-sync-user commented 6 months ago

➤ Matt Reagan commented:

Note: I’m not sure exactly when this regressed, though I rolled back to a commit from 3/18 and could see that it was working correctly at that time. (Attached an example video of how it’s expected to work)

!themechange.mov|width=640,height=444,alt="themechange.mov"!

data-sync-user commented 6 months ago

➤ Matt Reagan commented:

cc Alina Moldovan This is the theme bug for multi-window that I mentioned in the KO. It should be fixed now.

data-sync-user commented 5 months ago

➤ Diana Andreea Barladeanu commented:

Verified as fixed on v9000 (42142), with iPad Air 3rd gen (17.5).

!RPReplay_Final1716639285.mp4|width=720,height=960,alt="RPReplay_Final1716639285.mp4"!

data-sync-user commented 5 months ago

➤ Andrei Bodea commented:

Verified as fixed on v128 (42711) with iPad Pro (16.4.1).