search

mozilla-mobile / firefox-ios

Firefox for iOS
Mozilla Public License 2.0
12.23k stars 2.94k forks source link

Replace the Learn more button in Tracking Protection to use LinkButton in Component Library #20344

Open data-sync-user opened 6 months ago

data-sync-user commented 6 months ago

Replace the generic UIButton with the “learn more” title in ContentBlockerSettingViewController to be a LinkButton from the ComponentLibrary. Please include screenshot of before/after your changes on the PR.

!71694B44-6CE4-46C5-869D-34FDFA04CB09.jpg|width=590,height=1280!

┆Issue is synchronized with this Jira Task

bmihai23 commented 6 months ago

Hi @PARAIPAN9, I would like to work on this issue. Thanks 🙏🏻

PARAIPAN9 commented 6 months ago

@bmihai23 sure, go ahead!!

data-sync-user commented 5 months ago

➤ Cyndi Chin commented:

For QA, Please verify that link button now has an underline. See screenshots in github issue. Thank you~

https://github.com/mozilla-mobile/firefox-ios/pull/20392 ( https://github.com/mozilla-mobile/firefox-ios/pull/20392 )

data-sync-user commented 4 months ago

➤ Andrei Bodea commented:

Verified as fixed on v9000 (43238) with iPhone 15 Pro (17.5.1).

data-sync-user commented 4 months ago

➤ Diana Andreea Barladeanu commented:

Validated on v129 (43354), with iPhone 15 (17.5).

!ImportedPhoto.742206157.600152.jpeg|width=1179,height=2556,alt="ImportedPhoto.742206157.600152.jpeg"!