search

mozilla-mobile / firefox-ios

Firefox for iOS
Mozilla Public License 2.0
12.09k stars 2.88k forks source link

FF crashes after closing new customization onboarding tour when accessing "show tour" from settings [Intermittent} #20420

Open DianaABarladeanu opened 1 month ago

DianaABarladeanu commented 1 month ago

Steps to reproduce

  1. Fresh install FF.
  2. Go to settings -->show tour.
  3. Close the tour after sliding through some of the cards.

Expected behavior The onboarding tour closes and FF homepage is opened.

Actual behavior The app crashes. Also, one of the crash prompts is missing (the one with share to devs). Only the prompt regarding tab restoring is displayed.

Device & build information

Notes ! The crash reproduces only with the new customization onboarding tour and only when accessing "show tour" from settings, not at install.

Attachments:

https://github.com/mozilla-mobile/firefox-ios/assets/151131988/9e86044f-c1f3-40e9-8106-ff971b2cc613

Client-2024-05-27-135313.ips.zip

┆Issue is synchronized with this Jira Task

nbhasin2 commented 1 month ago

@DianaABarladeanu is it actually crashing or just showing the alert?

data-sync-user commented 1 month ago

➤ Norberto Andres Furlan commented:

Experiment is going to end on 127. Roux Buciu can you take a look to the crash report to see if there is any action for the future (if we decide to rollout)?

data-sync-user commented 1 month ago

➤ Norberto Andres Furlan commented:

Diana Andreea Barladeanu can you re-check this? The crash report doesn’t seem to be this crash. Thanks!

data-sync-user commented 1 month ago

➤ Diana Andreea Barladeanu commented:

Norberto Andres Furlan Nishant Bhasin I rechecked this issue on the latest 127 build (42366) and I am unable to reproduce it.

adudenamedruby commented 3 weeks ago

Hey ya'll. I've tested this pretty extensively just now on main and... I can't reproduce no matter what I do. I'mma put to QA needed. @DianaABarladeanu if you're happy that you can't reproduce either, we can close.

https://github.com/mozilla-mobile/firefox-ios/assets/11182210/358df8b6-02d1-468a-8e7a-7bf135721958

data-sync-user commented 2 weeks ago

➤ Diana Andreea Barladeanu commented:

Re-checked on v128 (42823), with iPhone 15 (17.5), I am unable to reproduce it.

Closing the ticket.