mozilla-mobile / firefox-ios

Firefox for iOS
Mozilla Public License 2.0
12.17k stars 2.92k forks source link

Firefox Suggest suggesting both deleted searches and searches from private windows #20451

Open SolventCookie77 opened 4 months ago

SolventCookie77 commented 4 months ago

Steps to reproduce

Searching a link multiple times anywhere, including in a private window.

Expected behavior

Only show links I have searched multiple times recently and links I have bookmarked.

Actual behavior

Firefox suggest will suggest links I have searched only in private tabs. After clearing search history, and reinstalling the Firefox app, the problem persists.

Device & build information

┆Issue is synchronized with this Jira Task

data-sync-user commented 4 months ago

➤ Norberto Andres Furlan commented:

Alina Moldovan Andrei Bodea Sorin Paraipan can you take a look to this? Can it be related to the limit? Is it solved?

data-sync-user commented 4 months ago

➤ Sorin Paraipan commented:

The issue was encountered using build 126.1. The removal of suggestions went in 126.2.

data-sync-user commented 4 months ago

➤ Norberto Andres Furlan commented:

Alina Moldovan can you confirm that this is reproducible on your side?

abodea commented 4 months ago

Hello, I tried on v127 (42448) with iPhone 15 Pro (17.5.1). Please note that I was not able to see any search suggestions from private browsing in normal browsing. I did over 50 searches in private browsing and not a single time it was not suggested in normal browsing. @SolventCookie77 do you mind sharing a video while reproducing this issue, please?