search

mozilla-mobile / firefox-ios

Firefox for iOS
Mozilla Public License 2.0
12.15k stars 2.91k forks source link

Update Fonts related to OneLineTableViewCell to use FXFontStyles #20467

Open data-sync-user opened 4 months ago

data-sync-user commented 4 months ago

This task is part of a series of tasks to standardizing fonts to start using FXFontStyles.

Background Context: Previously, we were using DefaultDynamicFontHelper and setting the text style, size and weight for each font, which sometimes did not match our design system. By using FXFontStyles, we can standardize our fonts and be more aligned with the design system.

Task: Please update how we set fonts in the Firefox iOS Project related:

OneLineTableViewCell

Acceptance Criteria:

Replace usage of DefaultDynamicFontHelper with FXFontStyles

If there are discrepancies in terms of replacing the old fonts with the new standard, we will need to bring design in to approve the PR.

Please provide before and after screenshots of the UI.

Reference:

Usage example: FXFontStyles.Regular.headline.scaledFont()

See this PR for example of standardizing fonts for Primary Button:

https://github.com/mozilla-mobile/firefox-ios/pull/18711/files

┆Issue is synchronized with this Jira Task

data-sync-user commented 3 months ago

➤ Cyndi Chin commented:

Please verify that fonts scale appropriately. See screenshots in PR for more details. Thank you!

data-sync-user commented 3 months ago

➤ Diana Andreea Barladeanu commented:

Validated on v128 (42915), with iPhone 15 (17.5).