search

mozilla-mobile / firefox-ios

Firefox for iOS
Mozilla Public License 2.0
12.14k stars 2.91k forks source link

[iPad Multi-Window] FF is not blurred while being in PWD section when adding the app to app switcher #20569

Open abodea opened 3 months ago

abodea commented 3 months ago

Steps to reproduce

  1. Launch FF and open it in split view.
  2. Login with a valid account and in one of the windows open PWD section.
  3. Add FF to the background (both windows).
  4. While being in the app switcher (and both FF windows are displayed).

    Expected behavior

    The window that is opened with the PWD manager should be blurred.

    Actual behavior

    FF is not blurred while being in the PWD section when adding the app to the app switcher

    Device & build information

    • Device: iPad Pro (16.4.1).
    • Build version: v9000 (42305)
    • First seen version: N/A

      Notes

      Attachments:

https://github.com/mozilla-mobile/firefox-ios/assets/42831109/1367a127-0b1c-4147-8d4b-440528906d08

┆Issue is synchronized with this Jira Task

data-sync-user commented 3 months ago

➤ Matt Reagan commented:

This may be an iOS bug with the window thumbnail, because in testing I can see that the blur is installed but it appears that the system preview of the window isn’t updated. Need to do a bit more digging into this.

data-sync-user commented 2 months ago

➤ Matt Reagan commented:

This appears to be related to the timing of when we perform the UI update, though I think it’s also partly an iPadOS bug; I added some test code which adds a 20pt red border to the VC’s view in the same code which installs the blur overlay and followed the same repro steps. You can see in the video that when the app is backgrounded the window thumbnail isn’t updated (when the app is brought forward you can see the red border briefly, it is there but the window thumbnail simply isn’t updated).

I tried changing this update to occur on willResignActiveNotification (instead of didEnterBackgroundNotification) which appears to correct the issue though there are broader implications to changing the notifications we use for this.

!blur bug.mov|width=640,height=444,alt="blur bug.mov"!

data-sync-user commented 2 months ago

➤ Andrei Bodea commented:

Verified as fixed on v128 (42711) with iPad Pro (16.4.1).

When adding now the FF to the app switcher, it’s blurred.