search

mozilla-mobile / firefox-ios

Firefox for iOS
Mozilla Public License 2.0
12.13k stars 2.9k forks source link

Display buttons in settings centered #20668

Open data-sync-user opened 2 months ago

data-sync-user commented 2 months ago

IMG_0028

IMG_0035

┆Issue is synchronized with this Jira Task

data-sync-user commented 2 months ago

➤ Alexandru Farcasanu commented:

Winnie Teichmann do you think we still need to change something?

Did some investigations here and: Clear Private Data text is already aligned to center in the cell.

!Screenshot 2024-06-18 at 15.16.19.png|width=478,height=20,alt="Screenshot 2024-06-18 at 15.16.19.png"!

Also, we can see exactly the same behaviour on the iPhone settings, for some buttons, like Sign Out from iCloud.

!ImportedPhoto.740406050.992909.jpeg|width=428,height=926,alt="ImportedPhoto.740406050.992909.jpeg"!

!ImportedPhoto.740406050.986137.jpeg|width=1284,height=2778,alt="ImportedPhoto.740406050.986137.jpeg"!

data-sync-user commented 2 months ago

➤ Winnie Teichmann commented:

Alexandru Farcasanu yes, the label is aligned to center but the cell content is not displayed centered. And yes, there are a places in our settings where the button label is not displayed centered with large dynamic type. All of these should be fixed in this task.

anna-yeddi commented 2 months ago

Marking it as access-S4 because the inconsistency may affect users with cognitive disabilities. Thank you for reporting it!

data-sync-user commented 2 months ago

➤ Alexandru Farcasanu commented:

For QA: Make sure Clear All Website Data, Disconnect Sync and Clear Private Data buttons from Settings are displayed and work correctly (centered, with warning color) regardless of text size choosed from iPhone settings.

data-sync-user commented 1 month ago

➤ Diana Andreea Barladeanu commented:

Validated on v9000 (43308), with iPhone 15 (17.5).

!ImportedPhoto.742113786.348243.jpeg|width=1179,height=2556,alt="ImportedPhoto.742113786.348243.jpeg"!

!ImportedPhoto.742113786.347333.jpeg|width=1179,height=2556,alt="ImportedPhoto.742113786.347333.jpeg"!

!ImportedPhoto.742113786.345991.jpeg|width=1179,height=2556,alt="ImportedPhoto.742113786.345991.jpeg"!

data-sync-user commented 1 month ago

➤ Diana Andreea Barladeanu commented:

Validated on v129 (43415), with iPhone 15 (17.5).