search

mozilla-mobile / firefox-ios

Firefox for iOS
Mozilla Public License 2.0
12.14k stars 2.9k forks source link

Remove theme manager use of UserDefaults and migration for private window state #20712

Open data-sync-user opened 2 months ago

data-sync-user commented 2 months ago

We recently changed the app to remove all private tabs between app launches. All feedback so far from Product is that this is a permanent change. This means we don’t need to persist private mode theme status for windows, so we don’t need to use UserDefaults in DefaultThemeManager.

We can also remove migrateSingleWindowPrivateDefaultsToMultiWindow

Related comments: https://github.com/mozilla-mobile/firefox-ios/pull/20667

┆Issue is synchronized with this Jira Task

data-sync-user commented 2 months ago

➤ Matt Reagan commented:

Internal refactor, no user-facing changes.