Refactor the RustRemoteTabs to directly use TabsStore instead of Tabs.swift

mozilla-mobile / firefox-ios

Firefox for iOS

Mozilla Public License 2.0

12.1k stars 2.88k forks source link

Refactor the RustRemoteTabs to directly use TabsStore instead of Tabs.swift #20775

Open skhamis opened 3 weeks ago

skhamis commented 3 weeks ago

RustRemoteTabs uses a wrapper for application services APIs called Tabs.swift https://github.com/mozilla/application-services/blob/main/components/tabs/ios/Tabs/Tabs.swift

It doesn't seem to do us much good and adds a layer of indirection needed for us to implement new APIs and debug issues with tabs. We should remove the wrapper and have RustRemoteTabs directly open the store.

┆Issue is synchronized with this Jira Task

data-sync-user commented 3 weeks ago

➤ Norberto Andres Furlan commented:

Sammy Khamis can you clarify what is this affecting to see if we need to run any regression testing? Thanks!

data-sync-user commented 3 weeks ago

➤ Sammy Khamis commented:

Ideally nothing will change! This is really just removing a layer of code that, probably at the time had some extra logic, but is just a simple wrapper around the code that lives in application services. For regression testing the main feature that uses this is:

Tab Syncing, Remote Tabs panel (seeing tabs from iOS on other platforms, and vice-versa)

data-sync-user commented 1 week ago

➤ Diana Andreea Barladeanu commented:

Validated on v9000 (43308), with iPhone 15 (17.5).

No issues encountered with tab syncing or remote tabs panel feature.

data-sync-user commented 4 days ago

➤ Diana Andreea Barladeanu commented:

Validated on v129 (43576), with iPhone 15 (17.5).