search

mozilla-mobile / firefox-ios

Firefox for iOS
Mozilla Public License 2.0
12.15k stars 2.91k forks source link

Update Fonts related to LegacyTabCell #21112

Open data-sync-user opened 2 months ago

data-sync-user commented 2 months ago

This task is part of a series of tasks to standardizing fonts to start using FXFontStyles.

Background Context: Previously, we were using DefaultDynamicFontHelper and setting the text style, size and weight for each font, which sometimes did not match our design system. By using FXFontStyles, we can standardize our fonts and be more aligned with the design system.

Task: Please update how we set fonts in the Firefox iOS Project related:

LegacyTabCell

Acceptance Criteria:

Replace usage of DefaultDynamicFontHelper with FXFontStyles

If there are discrepancies in terms of replacing the old fonts with the new standard, we will need to bring design in to approve the PR.

Please provide before and after screenshots of the UI.

Reference:

Usage example: FXFontStyles.Regular.headline.scaledFont()

See this PR for example of standardizing fonts for Primary Button:

https://github.com/mozilla-mobile/firefox-ios/pull/18711/files

┆Issue is synchronized with this Jira Task

yusuphjoluwasen commented 1 month ago

Hi, I would like to work on this issue

cyndichin commented 1 month ago

thank you for being interested in this issue, assigned the ticket to you.

cyndichin commented 3 weeks ago

@yusuphjoluwasen wanted to follow up if you were still interested in working on this, thank you!

yusuphjoluwasen commented 3 weeks ago

@cyndichin Yes, I am interested in working on the issue. I will submit a pull request before the end of the week. Thanks

cyndichin commented 3 weeks ago

great, thank you!

data-sync-user commented 5 days ago

➤ Cyndi Chin commented:

For QA, please test around the tab tray area, see screenshots in PR. This should be our legacy tab instead of the tab tray refactor though.