search

mozilla-mobile / firefox-ios

Firefox for iOS
Mozilla Public License 2.0
12.14k stars 2.91k forks source link

Enforce single UUID on iPhone devices to avoid potential iOS issues with multiple UUIDs #21124

Open data-sync-user opened 1 month ago

data-sync-user commented 1 month ago

This is an attempted bandaid/workaround to address the current hypothesis for the recent incident on 7/17 where we saw a spike of fatal log errors related to tab session data files not being found on iPhone devices (and iPad, however many of those cases were likely spurious errors, which is being addressed separately).

The plan is to hardcode and enforce a single UUID for iPhone devices since we know we never need (or should) to be creating more than 1. In theory if we have a problem where we are incorrectly creating a separate window + UUID on iPhone this should resolve that and also prevent any potential tab or data loss.

┆Issue is synchronized with this Jira Task

data-sync-user commented 1 month ago

➤ Matt Reagan commented:

cc Roux Buciu Orla Mitchell Norberto Andres Furlan

data-sync-user commented 1 month ago

➤ Matt Reagan commented:

Andrei Bodea This should impart no user-facing changes. Ideally we just need regression testing around iPhone (tab persistence and restoration etc.) and multi-window on iPad.

data-sync-user commented 1 month ago

➤ Andrei Bodea commented:

Verified as fixed on v128.3 (43849), with iPhone 15 Pro (17.5) and iPad Pro (16.4.1).

There are no issues with tab persistence or tab restoration.