mozilla-mobile / firefox-ios

Firefox for iOS
Mozilla Public License 2.0
12.14k stars 2.91k forks source link

[Tab tray] Tab thumbnails' dimensions have changed #21285

Open cpeterso opened 1 month ago

cpeterso commented 1 month ago

Steps to reproduce

  1. In both the Firefox 127 version from the App Store and a TestFlight Nightly 9000 build, open multiple tabs.
  2. Open the tab tray view.
  3. Rotate the device orientation to see the tab thumbnails in tab tray's portrait and landscape modes.
  4. Compare the dimensions of the thumbnails in the two different Firefox versions.

Expected behavior

The tab thumbnails should not be bigger or smaller than before.

Actual behavior

The thumbnails in Nightly are now;

Device & build information

┆Issue is synchronized with this Jira Task

cpeterso commented 1 month ago

Screenshot of Firefox 127's tab tray in landscape orientation:

image

cpeterso commented 1 month ago

Screenshot of TestFlight Nightly 9000 (43470)'s tab tray in landscape orientation:

image

ghost commented 4 weeks ago

@cpeterso I don't have an iPhone, but a Reddit user posted this screenshot that shows even larger tabs:

Screenshot
ghost commented 3 weeks ago

Just a note: I had already included the screenshot in my comment. I used spoiler tags because the screenshot looks huge on 1080p monitors:

<details>
<summary>Screenshot</summary>
<img src="https://github.com/user-attachments/assets/91bec09e-cfc2-4a5c-8977-79008f80594d"/>
</details>
cpeterso commented 3 weeks ago

oops. Thanks. I overlooked the collapsed screenshot. In that case, I'll delete my redundant comment.

ghost commented 2 weeks ago

Another user with huge tabs: https://old.reddit.com/r/firefox/comments/1f20ot1/my_layoutits_terrible/

data-sync-user commented 2 weeks ago

➤ Alina Moldovan commented:

CC Norberto Andres Furlan Orla Mitchell

We tried to reproduce this issue using FF versions: v127, v130, and V9000. Also, I split the unexpected results into 3 issues:

  1. The thumbnails' dimensions much narrowed in landscape orientation
  2. 4 thumbnails on a row while in landscape mode
  3. Huge tabs displayed in the tab tray - Not able to reproduce at all

The following cases were identified:

  1. A different behavior is present depending on the Test Flight channels we use:

    1. TF FF beta channel → Clean install, tab tray refactor not enabled:

      1. → The thumbnails' dimensions much narrowed in landscape orientation - the issue doesn't reproduce
      2. → 4 thumbnails on a row while in landscape mode - the issue reproduces
    2. TF FF channel:

      1. → The thumbnails' dimensions much narrowed in landscape orientation - the issue reproduces
      2. → 4 thumbnails on a row while in landscape mode - the issue doesn't reproduce
    3. Video: !v130 - comparation between TF channels.MOV|width=220,height=480,alt="v130 - comparation between TF channels.MOV"!

  2. TF FF beta channel: V127 with and without tab tray refactor being enabled

    1. Tab tray refactor not enabled

      1. → The thumbnails' dimensions much narrowed in landscape orientation - the issue reproduce
      2. → 4 thumbnails on a row while in landscape mode - the issue doesn't reproduce
    2. Tab tray refactor enabled

      1. → The thumbnails' dimensions much narrowed in landscape orientation - the issue doesn't reproduce
      2. → 4 thumbnails on a row while in landscape mode - the issue reproduce
    3. videos: !127 - tab tray refactor not enabled.MOV|width=220,height=480,alt="127 - tab tray refactor not enabled.MOV"!

!127 - tab tray refactor enabled.MOV|width=220,height=480,alt="127 - tab tray refactor enabled.MOV"!

  1. TF FF beta channel: V130 with and without tab tray refactor being enabled (same results for v9000 build)

    1. Tab tray refactor not enabled

      1. → The thumbnails' dimensions much narrowed in landscape orientation - the issue doesn't reproduce
      2. → 4 thumbnails on a row while in landscape mode - the issue reproduce
    2. Tab tray refactor enabled

      1. → The thumbnails' dimensions much narrowed in landscape orientation - the issue doesn't reproduce
      2. → 4 thumbnails on a row while in landscape mode - the issue reproduce
    3. videos: !v9000 - tab tray refactor enabed.MOV|width=220,height=480,alt="v9000 - tab tray refactor enabed.MOV"!

!130 - tab ray refactor enabled.MOV|width=220,height=480,alt="130 - tab ray refactor enabled.MOV"!

!v9000 - tab tray refactor not enabed.MOV|width=220,height=480,alt="v9000 - tab tray refactor not enabed.MOV"!

!130 - tab tray refactor not enabled.MOV|width=220,height=480,alt="130 - tab tray refactor not enabled.MOV"!