search

mozilla-mobile / firefox-ios

Firefox for iOS
Mozilla Public License 2.0
12.23k stars 2.94k forks source link

[Tab tray] [regression] Zoomed tab thumbnails no longer animate when opening #21341

Closed cpeterso closed 3 days ago

cpeterso commented 3 months ago

Steps to reproduce

  1. In both the Firefox 127 version from the App Store and a TestFlight Nightly 9000 build, open multiple tabs.
  2. Open the tab tray view.
  3. Long press on a tab thumbnail to see a zoomed thumbnail of the tab.

Expected behavior

The zoomed thumbnails should open using an expanding animation.

Actual behavior

The zoomed thumbnail opens without an animation.

This bug might be related to https://github.com/mozilla-mobile/firefox-ios/issues/21285 since they regressed in the same build.

Device & build information

┆Issue is synchronized with this Jira Task

dicarobinho commented 2 months ago

Hey @cpeterso you are talking about this zoom animation? When long press on a tab, all tabs are animated. Thank you.

https://github.com/user-attachments/assets/c10674fe-7490-4aea-b4bf-9fd24f378026

cpeterso commented 2 months ago

Your screen recording shows the bug I’m seeing:

  1. The tab preview pops open without a zoom animation.
  2. And closes using a zoom animation, but closing to the center point of the screen, not back to the tab thumbnail.

Expected behavior: Here is a screen recording of Firefox 130 installed from the App Store:

  1. The tab preview opens with a zoom animation from the tab thumbnail.
  2. And the tab preview closes with a zoom animation back to the tab thumbnail.

https://github.com/user-attachments/assets/57f8054e-19e3-4e48-8f79-310c17f6eb7c

cpeterso commented 2 months ago

Actual behavior: for comparison, here is a screen recording of the bug in Nightly 9000 (45068).

(Ignore that this recording is in private browsing mode; that’s not relevant to this bug.)

https://github.com/user-attachments/assets/bd17a6dc-a80c-4a0a-ac62-bfb301233890

dicarobinho commented 2 months ago

@cpeterso really appreciate your videos. Now, I clearly understand the issue. Thank you!

data-sync-user commented 3 weeks ago

➤ Diana Andreea Barladeanu commented:

Verified as fixed on v9000 (46854), with iPhone 15 (17.6)

data-sync-user commented 3 days ago

➤ Adina Petridean commented:

Verified as fixed on Firefox 133.0 (47401) with iPhone 14 Pro Max (iOS 16.2).